-
-
Notifications
You must be signed in to change notification settings - Fork 949
feat: Add Air Traffic Control for automatic link routing to workspaces, b=no-bug, c=workspaces #9042
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
meenie
wants to merge
8
commits into
zen-browser:dev
Choose a base branch
from
meenie:add-air-traffic-control
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+3,187
−9
Open
feat: Add Air Traffic Control for automatic link routing to workspaces, b=no-bug, c=workspaces #9042
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
b8ca114
feat: Add Air Traffic Control for automatic link routing to workspace…
meenie f045568
Ran npm run pretty
meenie 4a1216d
Address PR comments.
meenie 8b7b2b4
Merge branch 'dev' into add-air-traffic-control
b254d71
Merge branch 'dev' into add-air-traffic-control
mr-cheffy 89cbea8
Merge branch 'dev' into add-air-traffic-control
mr-cheffy df9949b
Merge branch 'dev' into add-air-traffic-control
mr-cheffy 0edcdd0
Merge branch 'dev' into add-air-traffic-control
mr-cheffy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,10 +1,11 @@ | ||
| diff --git a/browser/components/preferences/jar.mn b/browser/components/preferences/jar.mn | ||
| index 118709048e7de13f6ac10d0047e446b72303428f..c8cc2d7ee551b96be668a7844dab1db5abc9d684 100644 | ||
| index 118709048e7de13f6ac10d0047e446b72303428f..1bed8626c2d7e1e08885a07aac777bec02f6e4dd 100644 | ||
| --- a/browser/components/preferences/jar.mn | ||
| +++ b/browser/components/preferences/jar.mn | ||
| @@ -26,3 +26,5 @@ browser.jar: | ||
| @@ -26,3 +26,6 @@ browser.jar: | ||
| content/browser/preferences/widgets/setting-control.mjs (widgets/setting-control/setting-control.mjs) | ||
| content/browser/preferences/widgets/setting-group.mjs (widgets/setting-group/setting-group.mjs) | ||
| content/browser/preferences/widgets/setting-group.css (widgets/setting-group/setting-group.css) | ||
| + | ||
| + content/browser/preferences/zen-settings.js | ||
| + content/browser/preferences/zen-air-traffic-control.js | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we please have all these settings in the parent window as a dialog? Trying to avoid the preferences page as much as possible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think a need a little bit more clarity. Where should I put the affordance that would open up the dialog? Do you have an example where you've already done this in Zen?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@meenie unfortunately, I can't think of an example where we are currently doing this on zen.
But it would ideally just be the same XHTML contents but instead of being in the settings, it's opened via https://searchfox.org/mozilla-central/source/browser/base/content/browser.js#5250.
One example of this modal is when pressing CMD+Q on mac
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ya, for sure, makes sense. Just wondering where I should put the button to open it up? Should it be in a context menu somewhere? Or put a button in the preferences area that opens it up, kinda like how Arc does it themselves?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe here? @marat0n
Also, please ping me so I can know you wrote me