Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small feature PR that adds a new class
byte_array
which is an indexable array type for 8-bit types (signed / unsigned chars) of length 8. This is useful, as it's exactly what we use for the various kernels that do path tracing around the links of the lattice.With this class, we can use it instead of
thread_array
, the advantages ofbyte_array
being that it is lower latency, and does not consume any shared memory. E.g., saving more L1 cache which can be helpful for performance. On the kernels I tested, I saw either performance neutrality or a perf uplift.Also included here:
byte_array
instead ofthread_array
DeGrandRossi
contraction kernel (was due to some run-time indexing)