Mesh geometry utils #135
Open
Mesh geometry utils #135
+326
−81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pabloyesteb
force-pushed
the
mesh-geometry-utils-117
branch
from
e83632c to
671e8f1
Compare
|
closes #117 |
added 2 commits
March 24, 2025 13:35
…o mesh-geometry-utils-117
ArnauMiro
requested changes
Mar 24, 2025
ArnauMiro
reviewed
Mar 24, 2025
added 3 commits
March 24, 2025 15:14
…o mesh-geometry-utils-117
removed tqdm
…ht-reader Deleted dependency of Ensight
…esh-geometry-utils-117
…o mesh-geometry-utils-117
ArnauMiro
requested changes
Apr 10, 2025
There was a problem hiding this comment.
@pabloyesteb also ensure that your new functions within the Mesh class are properly documented. We will improve the documentation of the whole class soon.
|
@pabloyesteb also check that the new implementation of Once these check out, I'll finish implementing the compiled versions of these functions and we will be ready for a final test and merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented functions for computing the cells connectivity and edge normals. Added an example. The functions have been ckecked to properly compute the claimed data in ParaView.