Tests fail due to failed dependency with pyplomb

[ArnauMiro]

@bef-18 take a look at this:

ModuleNotFoundError: No module named 'pyplomb'

[ArnauMiro]

@bef-18 and since you're at it:

[ 2/12] Cythonizing pyLOM/POD/wrapper.pyx
warning: pyLOM/POD/wrapper.pyx:67:24: local variable 'X_var' referenced before assignment
warning: pyLOM/POD/wrapper.pyx:68:24: local variable 'X_var' referenced before assignment
warning: pyLOM/POD/wrapper.pyx:69:8: local variable 'X_var' referenced before assignment

You're missing to allocate X_var.

[ArnauMiro]

Oh, and @bef-18 we need a testsuite run for PCA.

[ArnauMiro]

And also check this compilation warning:

pyLOM/POD/wrapper.c: In function ‘__pyx_pf_5pyLOM_3POD_7wrapper__srun’:
pyLOM/POD/wrapper.c:20862:7: warning: implicit declaration of function ‘snorm_variance’; did you mean ‘stemporal_variance’? [-Wimplicit-function-declaration]
20862 |       snorm_variance(__pyx_v_Y, __pyx_v_Z, __pyx_v_X_var, __pyx_v_m, __pyx_v_n);
      |       ^~~~~~~~~~~~~~
      |       stemporal_variance
pyLOM/POD/wrapper.c: In function ‘__pyx_pf_5pyLOM_3POD_7wrapper_2_drun’:
pyLOM/POD/wrapper.c:21699:7: warning: implicit declaration of function ‘dnorm_variance’; did you mean ‘dtemporal_variance’? [-Wimplicit-function-declaration]
21699 |       dnorm_variance(__pyx_v_Y, __pyx_v_Z, __pyx_v_X_var, __pyx_v_m, __pyx_v_n);
      |       ^~~~~~~~~~~~~~
      |       dtemporal_variance
In function ‘__pyx_pf_5pyLOM_3POD_7wrapper__srun’,
    inlined from ‘__pyx_pw_5pyLOM_3POD_7wrapper_1_srun’ at pyLOM/POD/wrapper.c:20492:13:
pyLOM/POD/wrapper.c:20853:7: warning: ‘__pyx_v_X_var’ may be used uninitialized [-Wmaybe-uninitialized]
20853 |       stemporal_variance(__pyx_v_X_var, (&(*((float *) ( /* dim=1 */ (( /* dim=0 */ (__pyx_v_X.data + __pyx_t_13 * __pyx_v_X.strides[0]) ) + __pyx_t_14 * __pyx_v_X.strides[1]) )))), __pyx_v_X_mean, __pyx_v_m, __pyx_v_n);
      |       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
pyLOM/POD/wrapper.c: In function ‘__pyx_pw_5pyLOM_3POD_7wrapper_1_srun’:
pyLOM/POD/wrapper.c:20512:10: note: ‘__pyx_v_X_var’ was declared here
20512 |   float *__pyx_v_X_var;
      |          ^~~~~~~~~~~~~

[bef-18]

PCA just takes the run from POD and does a vecmat product between S and V to compute the scores. Then, the POD test should be enough to validate the PCA module.

[ArnauMiro]

Yeah, however, the normalization by the variance is not tested and thus we should create a test that does that.