Mesh geometry utils #135
Mesh geometry utils #135
Conversation
pabloyesteb
force-pushed
the
mesh-geometry-utils-117
branch
from
e83632c to
671e8f1
Compare
|
closes #117 |
…o mesh-geometry-utils-117
…o mesh-geometry-utils-117
…esh-geometry-utils-117
…o mesh-geometry-utils-117
There was a problem hiding this comment.
@pabloyesteb also ensure that your new functions within the Mesh class are properly documented. We will improve the documentation of the whole class soon.
|
@pabloyesteb also check that the new implementation of Once these check out, I'll finish implementing the compiled versions of these functions and we will be ready for a final test and merge. |
|
I've checked the edge_normals implementation in ParaView and everything is alright. Also, I've checked the documentation of my functions in mesh.py and everything seems to be in order to me. ¿Do you have any specific suggestions? |
…o mesh-geometry-utils-117
There was a problem hiding this comment.
@pabloyesteb can you check that the new compiled version of your routines produce the same expected result as the non compiled version?
|
|
||
| @cr('math.fix_coherence') | ||
| def fix_normals_coherence(normals, connectivity): | ||
| ''' |
| @cython.cdivision(True) # turn off zero division check | ||
| def fix_normals_coherence(real[:,:] normals, object edge_dict, object adjacency, int num_cells): | ||
| ''' |
Implemented functions for computing the cells connectivity and edge normals. Added an example. The functions have been ckecked to properly compute the claimed data in ParaView.