Skip to content

Commit c2985f5

Browse files
Make code a bit easier to read
1 parent 35fe72b commit c2985f5

File tree

1 file changed

+21
-17
lines changed

1 file changed

+21
-17
lines changed

photo-gallery/gallery.js

Lines changed: 21 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,26 @@ function formatISO(data) {
3939
return `${data.ISOSpeedRatings}`;
4040
}
4141

42+
function filterBy(filter) {
43+
switch (filter.id) {
44+
case 'camera-filter':
45+
filterByCamera(filter.value);
46+
break;
47+
case 'aperture-filter':
48+
filterByAperture(filter.value);
49+
break;
50+
case 'exposure-filter':
51+
filterByExposure(filter.value);
52+
break;
53+
case 'focal-length-filter':
54+
filterByFocalLength(filter.value);
55+
break;
56+
case 'iso-filter':
57+
filterByISO(filter.value);
58+
break;
59+
}
60+
}
61+
4262
function filterByCamera(camera) {
4363
populateGallery(IMAGES.filter(image => {
4464
if (!camera) return true;
@@ -379,23 +399,7 @@ addEventListener('input', e => {
379399
});
380400

381401
// Apply the filter based on the selected value.
382-
switch (filter.id) {
383-
case 'camera-filter':
384-
filterByCamera(filter.value);
385-
break;
386-
case 'aperture-filter':
387-
filterByAperture(filter.value);
388-
break;
389-
case 'exposure-filter':
390-
filterByExposure(filter.value);
391-
break;
392-
case 'focal-length-filter':
393-
filterByFocalLength(filter.value);
394-
break;
395-
case 'iso-filter':
396-
filterByISO(filter.value);
397-
break;
398-
}
402+
filterBy(filter);
399403

400404
// Add a mark in the Performance tool's recorded profile to
401405
// indicate that a filter was applied.

0 commit comments

Comments
 (0)