[Wami] Fix protocol_hanlders definition #64
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wami/manifest.json
Outdated
| @@ -32,7 +32,7 @@ | |||
| "protocol_handlers": [ | |||
| { | |||
| "protocol": "web+wami", | |||
| "url": "./?url=%s" | |||
| "url": "/?url=%s" | |||
There was a problem hiding this comment.
I'm fine with this change, but did you test it once packaged?
The potential problem I see is that the Demos repo is hosted at GitHub pages, and the demo URL is: https://microsoftedge.github.io/Demos/wami/.
If you register a url that starts with /, it will end up going to https//microsoftedge.github.io/(i.e. theDemos/wami` part will be removed).
captainbrosset
approved these changes
May 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Standard protocol_hanlders.url should all be relative URLs that are within the scope of the app. This PR aims to fix the issue.
With
., manifest check will fail in pwabuilder.comAfter replacing
., the error will be fixed.