Skip to content

Run format, lint and build #1719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

lucacome
Copy link
Contributor

@lucacome lucacome commented May 7, 2024

Seems like some files were not properly formatted and npm run build wasn't run.

This is the result of running npm run format && npm run lint && npm run build

Signed-off-by: Luca Comellini <luca.com@gmail.com>
@lucacome lucacome requested a review from a team as a code owner May 7, 2024 18:27
@joshmgross
Copy link
Contributor

👋 Hey @lucacome, thanks for your contribution!

I'm trying to reproduce this locally but I don't see any changes after running build, format, or lint:

~/actions/checkout main
❯ g pull    
Already up to date.

~/actions/checkout main
❯ node --version                                 
v20.6.1

~/actions/checkout main
❯ npm i                                          

up to date, audited 576 packages in 669ms

140 packages are looking for funding
  run `npm fund` for details

found 0 vulnerabilities

~/actions/checkout main
❯ npm run format && npm run lint && npm run build

> checkout@4.1.4 format
> prettier --write '**/*.ts'

__test__/git-auth-helper.test.ts 182ms (unchanged)
__test__/git-command-manager.test.ts 19ms (unchanged)
__test__/git-directory-helper.test.ts 28ms (unchanged)
__test__/git-version.test.ts 7ms (unchanged)
__test__/input-helper.test.ts 12ms (unchanged)
__test__/ref-helper.test.ts 8ms (unchanged)
__test__/retry-helper.test.ts 5ms (unchanged)
src/fs-helper.ts 3ms (unchanged)
src/git-auth-helper.ts 21ms (unchanged)
src/git-command-manager.ts 28ms (unchanged)
src/git-directory-helper.ts 5ms (unchanged)
src/git-source-provider.ts 13ms (unchanged)
src/git-source-settings.ts 2ms (unchanged)
src/git-version.ts 3ms (unchanged)
src/github-api-helper.ts 6ms (unchanged)
src/input-helper.ts 7ms (unchanged)
src/main.ts 2ms (unchanged)
src/misc/generate-docs.ts 5ms (unchanged)
src/ref-helper.ts 10ms (unchanged)
src/regexp-helper.ts 1ms (unchanged)
src/retry-helper.ts 4ms (unchanged)
src/state-helper.ts 2ms (unchanged)
src/url-helper.ts 3ms (unchanged)
src/workflow-context-helper.ts 2ms (unchanged)

> checkout@4.1.4 lint
> eslint src/**/*.ts


> checkout@4.1.4 build
> tsc && ncc build && node lib/misc/generate-docs.js

ncc: Version 0.38.1
ncc: Compiling file index.js into CJS
1316kB  dist/index.js
1316kB  [945ms] - ncc 0.38.1

~/actions/checkout main 6s
❯ git diff         

@cory-miller
Copy link
Contributor

cory-miller commented May 7, 2024

@lucacome

I tried a fresh codespace and do not get the diff you are seeing either by running the NPM commands.

In 9c1e94e#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519 I updated prettier from ^1.19.1 to ^3.2.5. If I revert back to the previous version and run the commands again, I see your output.

I'm going to close this out. If you can reproduce after updating prettier to match then feel free to re-open.

@cory-miller cory-miller closed this May 7, 2024
@lucacome lucacome deleted the build-lint branch May 7, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants