Skip to content

ci(test): set permissions in test workflow #247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 21, 2025

Conversation

joshmgross
Copy link
Contributor

This defines permissions on the test.yml workflow to align with our Actions security best-practices and ensure workflows only have the minimum required permissions.

@Copilot Copilot AI review requested due to automatic review settings May 5, 2025 14:57
@joshmgross joshmgross requested a review from a team as a code owner May 5, 2025 14:57
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a permissions block to the test.yml workflow to enforce least-privilege access for the GitHub token.

  • Defines contents: read to restrict repository content access.
  • Ensures the workflow aligns with security best practices by explicitly setting token permissions.

Copy link
Contributor

@gr2m gr2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that should work 👍🏼 We are accessing repository variables and secrets here but I don't think we need an extra permission for that, it's outside what the GITHUB_TOKEN secret is used for

@parkerbxyz parkerbxyz changed the title Set permissions in test workflow ci(test): set permissions in test workflow May 21, 2025
@joshmgross joshmgross merged commit dff4b11 into main May 21, 2025
5 checks passed
@joshmgross joshmgross deleted the joshmgross/wf-permissions branch May 21, 2025 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants