Skip to content

async void in unit tests #3824

Open
Open
@justindbaur

Description

@justindbaur

Describe the bug
My bug is not with github actions runners at all, it's just alerting to possibly poisoned tests in the codebase. This is just the only template that allows issue creation.

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://github.com/search?q=repo%3Aactions%2Frunner+%22async+void%22&type=code
  2. See that there are many tests using async void
  3. Read https://www.damirscorner.com/blog/posts/20220415-UsingAsyncVoidInXunitTests.html

Expected behavior
Expect async void tests to property fail if they are broken.

I would be more than happy to provide a PR converting these all to async Task

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions