-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Armbian repository signining: add new key #8323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
WalkthroughThe PGP public key block in the file Suggested labels
Suggested reviewers
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
✨ Finishing Touches🧪 Generate Unit Tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
config/armbian.key (1)
1-2
: Consider documenting key metadata.
Add a brief header above the PGP block with the key name, fingerprint, and validity period to aid future maintainers:+# Armbian Repository Signing Key (Repository Key) +# Fingerprint: 8CFA83D13EB2181EEF5843E41EB30FAF236099FE +# Created: 2025-06-22, Expires: 2035-06-20
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
config/armbian.key
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Shell script analysis
🔇 Additional comments (1)
config/armbian.key (1)
3-51
: ```bash
#!/usr/bin/env bashInstall PGPy to parse the ASCII-armored key
pip install pgpy >/dev/null
Parse the key and output expiration date
python3 << 'EOF'
import pgpyLoad the key
key, _ = pgpy.PGPKey.from_file("config/armbian.key")
Print only the expiration date in YYYY-MM-DD
expires = getattr(key, "expires_at", None)
print("Expires:", expires.strftime("%Y-%m-%d") if expires else "None")
EOF</details> </blockquote></details> </details> <!-- This is an auto-generated comment by CodeRabbit for review status -->
pub rsa4096 2025-06-22 [SC] [expires: 2035-06-20] 8CFA 83D1 3EB2 181E EF58 43E4 1EB3 0FAF 2360 99FE uid [ultimate] Armbian Repository Signing Key (Repository Key) <info@armbian.com> sub rsa4096 2025-06-22 [E] [expires: 2035-06-20]
Description
Add new key:
Reference: #8320
How Has This Been Tested?
Checklist: