Skip to content

Armbian repository signining: add new key #8323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

igorpecovnik
Copy link
Member

@igorpecovnik igorpecovnik commented Jun 23, 2025

Description

Add new key:

pub   rsa4096 2025-06-22 [SC] [expires: 2035-06-20]
      8CFA 83D1 3EB2 181E EF58  43E4 1EB3 0FAF 2360 99FE
uid           [ultimate] Armbian Repository Signing Key (Repository Key) <info@armbian.com>
sub   rsa4096 2025-06-22 [E] [expires: 2035-06-20]

Reference: #8320

How Has This Been Tested?

  • Added this key, sign repo and run apt update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Copy link
Contributor

coderabbitai bot commented Jun 23, 2025

Walkthrough

The PGP public key block in the file config/armbian.key has been replaced. The previous key, associated with an individual named Igor Pecovnik, has been removed and substituted with a new key for the "Armbian Repository Signing Key" with different key details and email. The version header line present in the old key has also been omitted in the new key. No other changes were made to the file structure or content.

Suggested labels

ready to merge

Suggested reviewers

  • igorpecovnik

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 155e128 and bef2f27.

📒 Files selected for processing (1)
  • config/armbian.key (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • config/armbian.key
✨ Finishing Touches
🧪 Generate Unit Tests
  • Create PR with Unit Tests
  • Post Copyable Unit Tests in Comment
  • Commit Unit Tests in branch newkey

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai auto-generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added 08 Milestone: Third quarter release size/medium PR with more then 50 and less then 250 lines Needs review Seeking for review Hardware Hardware related like kernel, U-Boot, ... labels Jun 23, 2025
@coderabbitai coderabbitai bot added the Ready to merge Reviewed, tested and ready for merge label Jun 23, 2025
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
config/armbian.key (1)

1-2: Consider documenting key metadata.
Add a brief header above the PGP block with the key name, fingerprint, and validity period to aid future maintainers:

+# Armbian Repository Signing Key (Repository Key)
+# Fingerprint: 8CFA83D13EB2181EEF5843E41EB30FAF236099FE
+# Created: 2025-06-22, Expires: 2035-06-20
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c9835d6 and 155e128.

📒 Files selected for processing (1)
  • config/armbian.key (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: Shell script analysis
🔇 Additional comments (1)
config/armbian.key (1)

3-51: ```bash
#!/usr/bin/env bash

Install PGPy to parse the ASCII-armored key

pip install pgpy >/dev/null

Parse the key and output expiration date

python3 << 'EOF'
import pgpy

Load the key

key, _ = pgpy.PGPKey.from_file("config/armbian.key")

Print only the expiration date in YYYY-MM-DD

expires = getattr(key, "expires_at", None)
print("Expires:", expires.strftime("%Y-%m-%d") if expires else "None")
EOF


</details>

</blockquote></details>

</details>

<!-- This is an auto-generated comment by CodeRabbit for review status -->

pub   rsa4096 2025-06-22 [SC] [expires: 2035-06-20]
      8CFA 83D1 3EB2 181E EF58  43E4 1EB3 0FAF 2360 99FE
uid           [ultimate] Armbian Repository Signing Key (Repository Key) <info@armbian.com>
sub   rsa4096 2025-06-22 [E] [expires: 2035-06-20]
@github-actions github-actions bot removed the Ready to merge Reviewed, tested and ready for merge label Jun 23, 2025
@coderabbitai coderabbitai bot added the Ready to merge Reviewed, tested and ready for merge label Jun 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
08 Milestone: Third quarter release Hardware Hardware related like kernel, U-Boot, ... Needs review Seeking for review Ready to merge Reviewed, tested and ready for merge size/medium PR with more then 50 and less then 250 lines
Development

Successfully merging this pull request may close these issues.

1 participant