This change adds case diff supress functions where needed to avoid (#299)

unnecessary resource recreate/update calls

Author: Nicholas M. Iodice

azuredevops/resource_agentpool.go

@@ -10,6 +10,7 @@ import (
 	"github.com/microsoft/terraform-provider-azuredevops/azuredevops/utils"
 	"github.com/microsoft/terraform-provider-azuredevops/azuredevops/utils/config"
 	"github.com/microsoft/terraform-provider-azuredevops/azuredevops/utils/converter"
+	"github.com/microsoft/terraform-provider-azuredevops/azuredevops/utils/suppress"
 	"github.com/microsoft/terraform-provider-azuredevops/azuredevops/utils/validate"
 )
 
@@ -30,10 +31,11 @@ func resourceAzureAgentPool() *schema.Resource {
 				ValidateFunc: validate.NoEmptyStrings,
 			},
 			"pool_type": {
-				Type:     schema.TypeString,
-				Optional: true,
-				ForceNew: true,
-				Default:  taskagent.TaskAgentPoolTypeValues.Automation,
+				Type:             schema.TypeString,
+				Optional:         true,
+				ForceNew:         true,
+				Default:          taskagent.TaskAgentPoolTypeValues.Automation,
+				DiffSuppressFunc: suppress.CaseDifference,
 				ValidateFunc: validation.StringInSlice([]string{
 					string(taskagent.TaskAgentPoolTypeValues.Automation),
 					string(taskagent.TaskAgentPoolTypeValues.Deployment),

azuredevops/resource_group_membership.go

@@ -13,6 +13,7 @@ import (
 	"github.com/microsoft/terraform-provider-azuredevops/azuredevops/utils"
 	"github.com/microsoft/terraform-provider-azuredevops/azuredevops/utils/config"
 	"github.com/microsoft/terraform-provider-azuredevops/azuredevops/utils/converter"
+	"github.com/microsoft/terraform-provider-azuredevops/azuredevops/utils/suppress"
 )
 
 func resourceGroupMembership() *schema.Resource {
@@ -30,9 +31,10 @@ func resourceGroupMembership() *schema.Resource {
 				ValidateFunc: validation.NoZeroValues,
 			},
 			"mode": {
-				Type:     schema.TypeString,
-				Optional: true,
-				Default:  "add",
+				Type:             schema.TypeString,
+				Optional:         true,
+				Default:          "add",
+				DiffSuppressFunc: suppress.CaseDifference,
 				ValidateFunc: validation.StringInSlice([]string{
 					"add", "overwrite",
 				}, true),

azuredevops/resource_project.go

@@ -46,19 +46,21 @@ func resourceProject() *schema.Resource {
 				Default:  "",
 			},
 			"visibility": {
-				Type:     schema.TypeString,
-				Optional: true,
-				Default:  core.ProjectVisibilityValues.Private,
+				Type:             schema.TypeString,
+				Optional:         true,
+				Default:          core.ProjectVisibilityValues.Private,
+				DiffSuppressFunc: suppress.CaseDifference,
 				ValidateFunc: validation.StringInSlice([]string{
 					string(core.ProjectVisibilityValues.Private),
 					string(core.ProjectVisibilityValues.Public),
 				}, false),
 			},
 			"version_control": {
-				Type:     schema.TypeString,
-				ForceNew: true,
-				Optional: true,
-				Default:  core.SourceControlTypesValues.Git,
+				Type:             schema.TypeString,
+				ForceNew:         true,
+				Optional:         true,
+				Default:          core.SourceControlTypesValues.Git,
+				DiffSuppressFunc: suppress.CaseDifference,
 				ValidateFunc: validation.StringInSlice([]string{
 					string(core.SourceControlTypesValues.Git),
 					string(core.SourceControlTypesValues.Tfvc),

azuredevops/resource_resource_authorization.go

@@ -9,6 +9,7 @@ import (
 	"github.com/microsoft/azure-devops-go-api/azuredevops/build"
 	"github.com/microsoft/terraform-provider-azuredevops/azuredevops/utils/config"
 	"github.com/microsoft/terraform-provider-azuredevops/azuredevops/utils/converter"
+	"github.com/microsoft/terraform-provider-azuredevops/azuredevops/utils/suppress"
 )
 
 const msgErrorFailedResourceCreate = "error creating authorized resource: %+v"
@@ -35,11 +36,12 @@ func resourceResourceAuthorization() *schema.Resource {
 				ValidateFunc: validation.IsUUID,
 			},
 			"type": {
-				Type:         schema.TypeString,
-				Optional:     true,
-				Default:      "endpoint",
-				Description:  "type of the resource",
-				ValidateFunc: validation.StringInSlice([]string{"endpoint"}, false),
+				Type:             schema.TypeString,
+				Optional:         true,
+				Default:          "endpoint",
+				Description:      "type of the resource",
+				DiffSuppressFunc: suppress.CaseDifference,
+				ValidateFunc:     validation.StringInSlice([]string{"endpoint"}, false),
 			},
 			"authorized": {
 				Type:        schema.TypeBool,

azuredevops/resource_user_entitlement.go

@@ -13,6 +13,7 @@ import (
 	"github.com/microsoft/azure-devops-go-api/azuredevops/memberentitlementmanagement"
 	"github.com/microsoft/terraform-provider-azuredevops/azuredevops/utils"
 	"github.com/microsoft/terraform-provider-azuredevops/azuredevops/utils/config"
+	"github.com/microsoft/terraform-provider-azuredevops/azuredevops/utils/suppress"
 )
 
 func resourceUserEntitlement() *schema.Resource {
@@ -33,11 +34,12 @@ func resourceUserEntitlement() *schema.Resource {
 				ForceNew: true,
 			},
 			"origin": {
-				Type:         schema.TypeString,
-				Optional:     true,
-				ForceNew:     true,
-				Default:      "aad",
-				ValidateFunc: validation.StringInSlice([]string{"aad", "ghb"}, false),
+				Type:             schema.TypeString,
+				Optional:         true,
+				ForceNew:         true,
+				Default:          "aad",
+				DiffSuppressFunc: suppress.CaseDifference,
+				ValidateFunc:     validation.StringInSlice([]string{"aad", "ghb"}, false),
 			},
 			"account_license_type": {
 				Type:     schema.TypeString,