Rust: Remove source vs library deduplication logic #19577
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hvitved
force-pushed
the
rust/remove-library-source-dedup-logic
branch
2 times, most recently
from
0c6570d to
17e53ae
Compare
hvitved
force-pushed
the
rust/remove-library-source-dedup-logic
branch
from
17e53ae to
d370452
Compare
hvitved
force-pushed
the
rust/remove-library-source-dedup-logic
branch
from
d370452 to
379c913
Compare
aibaars
approved these changes
Jul 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes path resolution logic for prioritizing source items over library items. However, the extractor already makes this deduplication, so there should be no need to do it in QL as well. Somewhat surprisingly, DCA shows a significant speedup (13 %).