Skip to content

Translated the labels for language ta [tamil] and re-formatted the byline to match how it is written in tamil #3449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 3, 2025

Conversation

balamt
Copy link
Contributor

@balamt balamt commented Jun 2, 2025

  • Have you followed the contributing guidelines?
  • Have you explained what your changes do, and why they add value to the Guides?

Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.


Screenshot of the Change tested in the Local machine:
Screenshot 2025-06-02 at 22 17 49

Test & HTML Proofer Result
Screenshot 2025-06-02 at 22 22 16


P.S: I'm working on the following translation as well.

balamt added 2 commits June 2, 2025 22:00
…ing-balance-for-open-source-maintainers

Translated the labels for language ta [tamil] and re-formatted byline
@Copilot Copilot AI review requested due to automatic review settings June 2, 2025 16:54
@balamt balamt requested a review from a team as a code owner June 2, 2025 16:54
@balamt balamt temporarily deployed to Pages Preview June 2, 2025 16:54 — with GitHub Actions Inactive
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Tamil locale file by translating the byline and associated label values to Tamil, and reformatting the byline structure to match Tamil writing conventions.

  • Updated the byline.format to reflect the new token order in Tamil.
  • Translated the code_label, love_label, and friends_label values.
Comments suppressed due to low confidence (1)

_data/locales/ta.yml:25

  • Ensure that the reordering of token placeholders in the 'format' value does not interfere with the token substitution logic elsewhere in the codebase. Confirm that token matching is based on label names rather than on position.
format: "[github] மற்றும் [friends] எழுதிய [love] [code]"

Copy link
Member

@jmeridth jmeridth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution. This looks good to me.

@jmeridth jmeridth added this pull request to the merge queue Jun 3, 2025
Merged via the queue into github:main with commit ff4ff0a Jun 3, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants