Skip to content

precision=day should return "today" instead of "now" #279

New issue
New issue
Closed
#280
Closed
precision=day should return "today" instead of "now"#279
#280
@jyasskin

Description

@jyasskin
jyasskin
opened on Mar 26, 2024
Contributor

https://jsfiddle.net/oabcw7mz/ has an example of trying to render (now - 23 hours) with a precision of days, which should show "today" but actually shows "now".

I think the fix will involve making getRelativeTimeUnit

relative-time-element/src/duration.ts

Lines 206 to 218 in a0483ce

export function getRelativeTimeUnit(
duration: Duration,
opts?: Partial<RoundingOpts>,
): [number, Intl.RelativeTimeFormatUnit] {
const rounded = roundToSingleUnit(duration, opts)
if (rounded.blank) return [0, 'second']
for (const unit of unitNames) {
if (unit === 'millisecond') continue
const val = rounded[`${unit}s` as keyof Duration] as number
if (val) return [val, unit]
}
return [0, 'second']
}

return the precision unit for empty durations.

Activity

keithamus

keithamus commented on Mar 26, 2024

@keithamus
keithamus
on Mar 26, 2024 · edited by keithamus
Contributor

Sounds like you have a good handle on the problem. Would you like to make a PR?

jyasskin
mentioned this on Mar 27, 2024
keithamus
closed this as completedin #280on Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      Participants

      @jyasskin@keithamus

      Issue actions
        precision=day should return "today" instead of "now" · Issue #279 · github/relative-time-element