Enable configurable log file for cloud-node-manager when running as a Windows service

[jrvaldes]

What would you like to be added:

azure-cloud-node-manager lacks of configurable option for log file location.

Why is this needed:

This feature is critical when running the azure-cloud-node-manager as a Windows service in a Windows host. That is:

azure-cloud-node-manager.exe --windows-service

The flag to adjust the log verbosity (--v) is present, but is practically unusable with the Windows service use case, given there is no visility of the logs.

For example:

azure-cloud-node-manager.exe --windows-service --v=5 ---log-file=C:\var\log\cloud-node-manager\cloud-node-manager.log

where --log-file set the path of the file to store the logs in the Windows host.

References:

cloud-provider-azure/cmd/cloud-node-manager/app/options/options.go

Line 125 in 6bc7669

fs := fss.FlagSet("misc")

[jrvaldes]

/cc @marosset @jsturtevant

[feiskyer]

Thanks for reporting the issue. @jrvaldes would you like to open a pull request and get it fixed?

[jrvaldes]

Thanks for reporting the issue. @jrvaldes would you like to open a pull request and get it fixed?

I’m open to it! @feiskyer Could you share guidelines or expectations for the implementation before I proceed?

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue as fresh with /remove-lifecycle stale
• Close this issue with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue as fresh with /remove-lifecycle rotten
• Close this issue with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Reopen this issue with /reopen
• Mark this issue as fresh with /remove-lifecycle rotten
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

[k8s-ci-robot]

@k8s-triage-robot: Closing this issue, marking it as "Not Planned".

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Reopen this issue with /reopen
• Mark this issue as fresh with /remove-lifecycle rotten
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.