Skip to content

plugin-management: make a library? #2197

Closed
@illume

Description

@illume

The plugin-management code is used by the app and headlamp-plugin. However, the previous solution for code sharing didn't work.

So plugin-management was copied into the app/. Temporarily. It was also converted to typescript.

I suggest it is turned into a new package @headlamp-k8s/plugin-management, which can be used by headlamp-plugin and the app/. Probably it should stay in ts.

Acceptance criteria

  • PluginManager.list fails if there is no plugins folder headlamp-k8s/plugins@72af907
  • PluginManager.list todo headlamp-k8s/plugins@64ad979
  • there is a @headlamp-k8s/plugin-management library released that can be used by app/ and headlamp-plugin
  • there is documentation on how to make changes to it in development (using npm link or npm pack or whatever)
  • there are docs on how to publish it
  • installing/removing plugins works in the app
  • tests pass (unit tests, and also headlamp-plugin e2e tests)

@yolossn For after the release... What do you think of this proposal?

Metadata

Metadata

Assignees

No one assigned

    Labels

    appfrontendIssues related to the frontendheadlamp-pluginRelated to the headlamp-plugin NPM package.

    Type

    No type

    Projects

    Status

    Queued

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions