headlamp-plugin: npm start puts plugin in wrong folder

[illume]

Describe the bug

headlamp-plugin: npm start puts plugin in wrong folder

Additionally, there should probably be a warning (in headlamp UI and npm start?) if two of a plugin is added from different folders. The package.json probably has the same name.

TODO: bisect when this changed.

To Reproduce

Steps to reproduce the bug:

1. go to a plugin like headlamp-k8s/minikube
2. npm install
3. npm start
4. See the plugin is placed in the folder "minikube" not "headlamp-k8s-minikube" as it is when installed via the plugin-catalog.

to test changes to headlamp-plugin

To test in development headlamp-plugin you can do:

cd plugins/headlamp-plugin
npm run build && npm pack

Then within one of the plugins with package.json name == @headlamp-k8s/XXX do

cd plugins/minikube
npm i ../../headlamp/plugins/headlamp-plugin/kinvolk-headlamp-plugin-0.13.0-alpha.3.tgz
npm start

Then look at the plugin folder (see backend output for where the plugins folder is if you are not running linux):

ls ~/.config/Headlamp/plugins

[andoriyaprashant]

Hello @illume I would like to work on this issue. Could you please assign it to me

Thank you

[shiavm006]

hello @illume i would like to work on this issue ..... can u pls assign it to make i think i can resolve it

[blazethunderstorm]

/assign

[blazethunderstorm]

@illume would love working on this issue and would soon make its pr , thanks

[blazethunderstorm]

@illume i have made pr pls review

[illume]

I checked out plugin-catalog 0.1.1

 npm start

> @headlamp-k8s/plugin-catalog@0.1.1 start
> headlamp-plugin start

Checking if @kinvolk/headlamp-plugin is up to date...
<i> [FileManagerPlugin] copied "./package.json" to "/home/rene/.config/Headlamp/plugins/plugin-catalog/package.json
<i> [FileManagerPlugin] copied "./dist/*" to "/home/rene/.config/Headlamp/plugins/plugin-catalog

It seems that the old headlamp-plugin does not put it into a headlamp-k8s/plugin-catalog path.

What does put it into a headlamp-k8s/plugin-catalog path is installing the plugin via the app.

[illume]

I'm thinking that probably the backend/ should return only the full path plugin. That is NOT return "minikube", but DO return "headlamp-k8s-minikube" if both exist.