Skip to content

Update headlamp-plugin and charts to use pluginctl package #3465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Faakhir30
Copy link
Contributor

Followup from #3455

  • Reuse pluginctl in headlamp-plugin
  • Use pluginctl for pluginManager in charts
  • Update headlamp-plugin readme

Testing

tested using npm link.

  1. Create a global symlink:
cd plugins/pluginctl
npm link
  1. In the project where you want to use the local version:
npm link @headlamp-k8s/pluginctl
  1. Run tests for unpublished headlamp-plugin
    cd plugins/headlamp-plugin && ./test-headlamp-plugin.js

Note: This PR requires #3455 to be merged first and @headlamp-k8s/pluginctl package to be released first.

Signed-off-by: Faakhir30 <zahidfaakhir@gmail.com>
Signed-off-by: Faakhir30 <zahidfaakhir@gmail.com>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 11, 2025
@k8s-ci-robot k8s-ci-robot requested review from sniok and yolossn June 11, 2025 14:44
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Faakhir30
Once this PR has been reviewed and has the lgtm label, please assign illume for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jun 11, 2025
@Hazmi35
Copy link

Hazmi35 commented Jun 12, 2025

I would've prefer to not use npm at all here and provide an image for pluginctl.

@Faakhir30 Faakhir30 force-pushed the pluginctl-updates branch from 7a091e2 to 9dbd9be Compare June 18, 2025 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants