-
Notifications
You must be signed in to change notification settings - Fork 375
frontend : Sidebar : Fixed "Network" Icon inconsistency between Sidebar and ResourceMap #3489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Welcome @sidd190! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks @sidd190!
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it should be the other way around. In the sidebar we've been using mdi:folder-network-outline icon for much longer, so the one in the Map is incorrect.
Could you please instead change the icon to mdi:folder-network-outline
in the Map instead?
aah, alright. I'll update it. |
New changes are detected. LGTM label has been removed. |
Alright, updated! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice, thanks!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mboersma, sidd190, sniok The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks @mboersma . Can you run |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
echoing the previous comment, also wanted to point out: be sure to condense the changes into an atomic commit as per our contribution guidelines
Summary
This PR fixes the inconsistent Network icon in Sidebar and ResourceMap.
Fixes #3485
Changes Made
-Updated the useSidebarItems.ts to use the better mdi, i.e. lan instead of folder-network-outline.