Move cluster chooser to the sidebar #3504
Open
+139
−66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This action is shown at the end of the sidebar item and can be used to display things like e.g. a cluster chooser, a bookmark/favorites button, etc. Signed-off-by: Joaquim Rocha <joaquim.rocha@microsoft.com>
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: joaquimrocha The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
And disable the cluster chooser button. The logic for the cluster chooser button however remains, in order to support the plugin-registered chooser components. Signed-off-by: Joaquim Rocha <joaquim.rocha@microsoft.com>
joaquimrocha
force-pushed
the
move-cluster-chooser
branch
from
622c74a to
c05ada8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does the following:
What's missing
How to test
Since I may not be able to advance much more on it, I'd like @sniok to check it out and eventually add the missing parts (the branch is in the headlamp-k8s org).
fixes #3189