-
Notifications
You must be signed in to change notification settings - Fork 333
doc: document which LB type each annotation is supported #1163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This issue is currently awaiting triage. If cloud-provider-aws contributors determine this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Hi @mtulio. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This change introduce a column to the Service Annotation documentation to make clear to users which annotation is valid for each LB type, preventing user's confusing when trying, for example, using an annotation not yet implemented for NLB.
9ab13af
to
6ac99ab
Compare
What type of PR is this?
/kind documentation
What this PR does / why we need it:
This change introduce a column to the Service Annotation documentation
to make clear to users which annotation is valid for each LB type,
preventing user's confusing when trying, for example, using an
annotation not yet implemented for NLB.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Please let me know if this information is already in another place that I didn't found. I used need to walk through the code to check if annotation is implemented in NLB. Thanks
Does this PR introduce a user-facing change?: