-
Notifications
You must be signed in to change notification settings - Fork 333
chore: update go version to 1.24 in 1.31 release #1166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This issue is currently awaiting triage. If cloud-provider-aws contributors determine this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Hi @shvbsle. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
I don't think this fixes the mentioned issue until you run the image promo. |
We are unable to run image-promo on 1.31.6 since the last-release was over 60 days old and objects in staging bucket expire after 60 days. The only way is to bump up the version to 1.31.7 but there were no changes added to 1.31 release since last bump of 1.31.6. This PR has some maintenance that can be used to cut a release and then we can run image-promo for 1.31.7 |
@@ -14,15 +14,15 @@ | |||
## BUILD ARGS ## | |||
################################################################################ | |||
# This build arg allows the specification of a custom Golang image. | |||
ARG GOLANG_IMAGE=golang:1.22.7 | |||
ARG GOLANG_IMAGE=golang:1.24.4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why directly 1.31? can we update the go version on master and then cherry pick for other versions?
Closing this. There is a PR for master: #1170 Will raise another PR to cherry pick into 1.31 |
What type of PR is this?
What this PR does / why we need it:
This updates the go version of 1.31 releases to 1.24. After bumping the version up during the release, we should be able to promote the image and artifacts for 1.31
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
To test this I ran:
And ensured that build succeeds and tests pass.
Does this PR introduce a user-facing change?: