Skip to content

chore: update go version to 1.24 in 1.31 release #1166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

shvbsle
Copy link
Contributor

@shvbsle shvbsle commented Jun 17, 2025

What type of PR is this?

Uncomment only one, leave it on its own line:

/kind feature

What this PR does / why we need it:
This updates the go version of 1.31 releases to 1.24. After bumping the version up during the release, we should be able to promote the image and artifacts for 1.31

Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
To test this I ran:

make
make test

And ensured that build succeeds and tests pass.

Does this PR introduce a user-facing change?:

NONE

@shvbsle shvbsle changed the title Release 1.31 chore: update go version to 1.24 in 1.31 release Jun 17, 2025
@k8s-ci-robot k8s-ci-robot added the release-note-none Denotes a PR that doesn't merit a release note. label Jun 17, 2025
@k8s-ci-robot k8s-ci-robot requested review from hakman and olemarkus June 17, 2025 19:56
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 17, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign nckturner for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 17, 2025
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If cloud-provider-aws contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot
Copy link
Contributor

Hi @shvbsle. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 17, 2025
@fletcherw
Copy link
Contributor

I don't think this fixes the mentioned issue until you run the image promo.

@shvbsle
Copy link
Contributor Author

shvbsle commented Jun 17, 2025

I don't think this fixes the mentioned issue until you run the image promo.

We are unable to run image-promo on 1.31.6 since the last-release was over 60 days old and objects in staging bucket expire after 60 days. The only way is to bump up the version to 1.31.7 but there were no changes added to 1.31 release since last bump of 1.31.6. This PR has some maintenance that can be used to cut a release and then we can run image-promo for 1.31.7

@@ -14,15 +14,15 @@
## BUILD ARGS ##
################################################################################
# This build arg allows the specification of a custom Golang image.
ARG GOLANG_IMAGE=golang:1.22.7
ARG GOLANG_IMAGE=golang:1.24.4
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why directly 1.31? can we update the go version on master and then cherry pick for other versions?

@shvbsle
Copy link
Contributor Author

shvbsle commented Jun 20, 2025

Closing this. There is a PR for master: #1170

Will raise another PR to cherry pick into 1.31

@shvbsle shvbsle closed this Jun 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants