Skip to content

Add mengqiy to milestone maintainer #5449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add mengqiy to milestone maintainer #5449

wants to merge 1 commit into from

Conversation

mengqiy
Copy link
Member

@mengqiy mengqiy commented Mar 6, 2025

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/github-management Issues or PRs related to GitHub Management subproject sig/release Categorizes an issue or PR as relevant to SIG Release. labels Mar 6, 2025
@k8s-ci-robot k8s-ci-robot requested review from gracenng and xmudrii March 6, 2025 07:53
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 6, 2025
@shyamjvs
Copy link
Member

shyamjvs commented Mar 7, 2025

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 7, 2025
@mengqiy
Copy link
Member Author

mengqiy commented Mar 12, 2025

/assign @cpanato

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 8, 2025
@Priyankasaggu11929
Copy link
Member

Hello @mengqiy, are these PR changes still needed? If yes, could you please rebase the PR? Thanks!

@Priyankasaggu11929
Copy link
Member

Hello @mengqiy, are these PR changes still needed? If yes, could you please rebase the PR? Thanks!

bumping again.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 17, 2025
@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mengqiy, shyamjvs
Once this PR has been reviewed and has the lgtm label, please ask for approval from cpanato. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 17, 2025
@mengqiy
Copy link
Member Author

mengqiy commented Jun 17, 2025

@Priyankasaggu11929 Rebased

@mengqiy
Copy link
Member Author

mengqiy commented Jun 17, 2025 •
edited
Loading

/cc @cpanato

@k8s-ci-robot k8s-ci-robot requested a review from cpanato June 17, 2025 19:04
cpanato
cpanato suggested changes Jun 17, 2025
View reviewed changes
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

per the issue kubernetes/community#8370

should we offboard shyamjvs from this list as well?

/hold for clarification

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpanato cpanato cpanato requested changes

@gracenng gracenng Awaiting requested review from gracenng

@xmudrii xmudrii Awaiting requested review from xmudrii

Assignees

@cpanato cpanato

@shyamjvs shyamjvs

Labels
area/github-management Issues or PRs related to GitHub Management subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. sig/release Categorizes an issue or PR as relevant to SIG Release. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mengqiy @shyamjvs @Priyankasaggu11929 @k8s-ci-robot @cpanato