Skip to content

etcd: Add unit test for release-3.5 branch #35011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 22, 2025

Conversation

joshjms
Copy link
Member

@joshjms joshjms commented Jun 20, 2025

Adding unit test postsubmits and periodics. Continuing #35000.

Ref: #32754

/cc @ivanvc @abdurrehman107

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/config Issues or PRs related to code in /config area/jobs size/M Denotes a PR that changes 30-99 lines, ignoring generated files. sig/etcd Categorizes an issue or PR as relevant to SIG Etcd. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jun 20, 2025
Copy link
Member

@ivanvc ivanvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Joshua. I'm just realizing that we forgot to add arm64 unit tests, too. I was reviewing the code from before we split that architecture into prow jobs, and we used to run arm64 unit tests, but forgot to migrate them.

Could you please enable arm64 in this pull request? Thanks :)

@joshjms
Copy link
Member Author

joshjms commented Jun 20, 2025

Ah I see, got it I'll add them

@joshjms joshjms changed the title etcd: Add unit test postsubmits and periodics for release-3.5 branch etcd: Add unit test for release-3.5 branch Jun 20, 2025
Signed-off-by: joshjms <joshjms1607@gmail.com>
@joshjms joshjms force-pushed the etcd-unit-test-release-3.5 branch from ab0c6bc to 2ea9150 Compare June 20, 2025 14:25
Copy link
Member

@ivanvc ivanvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Thanks, @joshjms.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 22, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ivanvc, joshjms

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 22, 2025
@k8s-ci-robot k8s-ci-robot merged commit dddbac3 into kubernetes:master Jun 22, 2025
7 checks passed
@k8s-ci-robot
Copy link
Contributor

@joshjms: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key etcd-periodics.yaml using file config/jobs/etcd/etcd-periodics.yaml
  • key etcd-postsubmits.yaml using file config/jobs/etcd/etcd-postsubmits.yaml
  • key etcd-presubmits.yaml using file config/jobs/etcd/etcd-presubmits.yaml

In response to this:

Adding unit test postsubmits and periodics. Continuing #35000.

Ref: #32754

/cc @ivanvc @abdurrehman107

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/etcd Categorizes an issue or PR as relevant to SIG Etcd. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants