-
Notifications
You must be signed in to change notification settings - Fork 2.7k
etcd: Add unit test for release-3.5 branch #35011
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
etcd: Add unit test for release-3.5 branch #35011
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, Joshua. I'm just realizing that we forgot to add arm64 unit tests, too. I was reviewing the code from before we split that architecture into prow jobs, and we used to run arm64 unit tests, but forgot to migrate them.
Could you please enable arm64 in this pull request? Thanks :)
Ah I see, got it I'll add them |
Signed-off-by: joshjms <joshjms1607@gmail.com>
ab0c6bc
to
2ea9150
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
Thanks, @joshjms.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ivanvc, joshjms The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@joshjms: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Adding unit test postsubmits and periodics. Continuing #35000.
Ref: #32754
/cc @ivanvc @abdurrehman107