Skip to content

Disable redundant pull-containerd-build job #35046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 8, 2025

Conversation

chrishenzie
Copy link
Member

This job's function of building containerd artifacts on pull requests is already covered by the binaries job in containerd's GitHub Actions: https://github.com/containerd/containerd/blob/v2.1.3/.github/workflows/ci.yml#L183

Disabling this job is a step towards the larger goal of migrating containerd's CI off of the community-owned prow.k8s.io infrastructure.

Disabling this job by setting always_run: false and optional: true as a non-disruptive first step before its eventual removal.

/assign @BenTheElder

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 27, 2025
@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config area/jobs sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jun 27, 2025
This job's function of building containerd artifacts on pull requests is
already covered by the `binaries` job in containerd's GitHub Actions:
https://github.com/containerd/containerd/blob/v2.1.3/.github/workflows/ci.yml#L183

Disabling this job is a step towards the larger goal of migrating
containerd's CI off of the community-owned `prow.k8s.io` infrastructure.

Disabling this job by setting `always_run: false` and `optional: true`
as a non-disruptive first step before its eventual removal.

Signed-off-by: Chris Henzie <chrishenzie@google.com>
@chrishenzie chrishenzie force-pushed the containerd-prow-jobs branch from 988014e to 91e54b7 Compare June 27, 2025 06:07
@BenTheElder
Copy link
Member

/approve
/hold

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 27, 2025
@kannon92
Copy link
Contributor

kannon92 commented Jul 3, 2025

/lgtm

@BenTheElder any reason for the hold?

Can we merge this?

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 3, 2025
@kannon92 kannon92 moved this from Triage to PRs - Needs Approver in SIG Node CI/Test Board Jul 3, 2025
@BenTheElder
Copy link
Member

@BenTheElder any reason for the hold?

Just to let someone else from containerd take a look [note also no lgtm].

Usually if a hold is meant to have particular requirements we spell them out, that was just "I don't have full context but this test-infra change looks OK"

/hold-cancel

Copy link
Contributor

@dmcgowan dmcgowan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, shouldn't be anything on containerd side relying on it

@k8s-ci-robot
Copy link
Contributor

@dmcgowan: changing LGTM is restricted to collaborators

In response to this:

Makes sense, shouldn't be anything on containerd side relying on it

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, chrishenzie, dmcgowan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@BenTheElder
Copy link
Member

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 8, 2025
@k8s-ci-robot k8s-ci-robot merged commit d0a1096 into kubernetes:master Jul 8, 2025
7 checks passed
@github-project-automation github-project-automation bot moved this from PRs - Needs Approver to Done in SIG Node CI/Test Board Jul 8, 2025
@k8s-ci-robot
Copy link
Contributor

@chrishenzie: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key containerd-presubmit-jobs.yaml using file config/jobs/containerd/containerd/containerd-presubmit-jobs.yaml

In response to this:

This job's function of building containerd artifacts on pull requests is already covered by the binaries job in containerd's GitHub Actions: https://github.com/containerd/containerd/blob/v2.1.3/.github/workflows/ci.yml#L183

Disabling this job is a step towards the larger goal of migrating containerd's CI off of the community-owned prow.k8s.io infrastructure.

Disabling this job by setting always_run: false and optional: true as a non-disruptive first step before its eventual removal.

/assign @BenTheElder

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@chrishenzie chrishenzie deleted the containerd-prow-jobs branch July 8, 2025 21:17
@mikebrow
Copy link
Member

This job's function of building containerd artifacts on pull requests is already covered by the binaries job in containerd's GitHub Actions: https://github.com/containerd/containerd/blob/v2.1.3/.github/workflows/ci.yml#L183

Disabling this job is a step towards the larger goal of migrating containerd's CI off of the community-owned prow.k8s.io infrastructure.

Disabling this job by setting always_run: false and optional: true as a non-disruptive first step before its eventual removal.

/assign @BenTheElder

nod we put it in there as insurance for prow .. why run the bigger job if build fails.. also at one point I believe the build output was cached.. May have been lost in the process of moving off prior ci tooling

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
Development

Successfully merging this pull request may close these issues.

6 participants