-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Disable redundant pull-containerd-build job #35046
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable redundant pull-containerd-build job #35046
Conversation
This job's function of building containerd artifacts on pull requests is already covered by the `binaries` job in containerd's GitHub Actions: https://github.com/containerd/containerd/blob/v2.1.3/.github/workflows/ci.yml#L183 Disabling this job is a step towards the larger goal of migrating containerd's CI off of the community-owned `prow.k8s.io` infrastructure. Disabling this job by setting `always_run: false` and `optional: true` as a non-disruptive first step before its eventual removal. Signed-off-by: Chris Henzie <chrishenzie@google.com>
988014e
to
91e54b7
Compare
/approve |
/lgtm @BenTheElder any reason for the hold? Can we merge this? |
Just to let someone else from containerd take a look [note also no lgtm]. Usually if a hold is meant to have particular requirements we spell them out, that was just "I don't have full context but this test-infra change looks OK" /hold-cancel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense, shouldn't be anything on containerd side relying on it
@dmcgowan: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BenTheElder, chrishenzie, dmcgowan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel |
@chrishenzie: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
nod we put it in there as insurance for prow .. why run the bigger job if build fails.. also at one point I believe the build output was cached.. May have been lost in the process of moving off prior ci tooling |
This job's function of building containerd artifacts on pull requests is already covered by the
binaries
job in containerd's GitHub Actions: https://github.com/containerd/containerd/blob/v2.1.3/.github/workflows/ci.yml#L183Disabling this job is a step towards the larger goal of migrating containerd's CI off of the community-owned
prow.k8s.io
infrastructure.Disabling this job by setting
always_run: false
andoptional: true
as a non-disruptive first step before its eventual removal./assign @BenTheElder