contrib guide: broken links and release versioning #505
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: miacycle <184569369+miacycle@users.noreply.github.com>
✅ Deploy Preview for bejewelled-pegasus-b0ce81 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
miacycle
requested review from
zihanKuang and
leecalcote
and removed request for
zihanKuang
zihanKuang
reviewed
Apr 26, 2025
leecalcote
reviewed
Apr 26, 2025
| @@ -257,7 +257,7 @@ The versioned sites follow this convention: | |||
| * `vXXX-YYY.docs.layer5.io` points to the release at vXXX.YYY-branch | |||
|
|
|||
| We also hook up each version to the dropdown on the website menu bar. | |||
| For information on how to update the website to a new version, see the [Layer5 release guide](https://github.com/layer5io/docs/blob/master/docs_dev/releasing.md#releasing-a-new-version-of-the-website). | |||
| For information on how to update the website to a new version, see the [Layer5 release guide](https://github.com/layer5io/docs/blob/master/docs_dev/releasing.md#releasing-a-new-version-of-the-website). --> | |||
There was a problem hiding this comment.
I wonder if this --> gets properly interpreted or not.
Co-authored-by: Zihan Kuang <127078886+zihanKuang@users.noreply.github.com> Signed-off-by: Mia Grenell <184569369+miacycle@users.noreply.github.com>
|
Merge conflicts |
|
@zihanKuang will you take over this PR? |
|
Please! |
|
@zihanKuang, will be working this one? |
|
Yes, I will take over this PR and resolve the merge conflicts.👍 |
Signed-off-by: Zihan Kuang <zihan_kuang@outlook.com>
Signed-off-by: Zihan Kuang <zihan_kuang@outlook.com>
leecalcote
pushed a commit
that referenced
this pull request
Jun 10, 2025
contrib guide: broken links and release versioning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: miacycle 184569369+miacycle@users.noreply.github.com