Enhance Embed Shortcode and Add "Understanding Edge Styles" Guide #603
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for bejewelled-pegasus-b0ce81 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
zihanKuang
changed the title
Signed-off-by: Zihan Kuang <zihan_kuang@outlook.com>
leecalcote
approved these changes
Jun 13, 2025
|
Uh-oh - a merge conflict. Once this has been fixed, please merge @zihanKuang @vishalvivekm |
Signed-off-by: Zihan Kuang <127078886+zihanKuang@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes for Reviewers
This PR introduces a guide for "Understanding Edge Styles". The new page explains the distinction between semantic and non-semantic edges, their default styles, and the full range of customization options in Kanvas. The guide uses a new GIF and embedded designs for clear visual examples.
To support this, the
meshery-design-embedshortcode has been enhanced. It now accepts asizeparameter ("full" or "half"), offering a simpler way to control the display of embedded designs.