Implemented Heading Permalinks with Hover/Visible Chain Icon #596 #606
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for bejewelled-pegasus-b0ce81 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
zihanKuang
requested changes
Jun 16, 2025
There was a problem hiding this comment.
Hi @HIMU-2001 , great work!
It seems you've accidentally mixed in content from your other PR: https://github.com/layer5io/docs/pull/604/files. If you could please remove those changes, we can get this merged.👍
Signed-off-by: HIMANSHU RAI <himanshuuu.2001@gmail.com>
HIMU-2001
force-pushed
the
heading-permalinks
branch
from
783073f to
4bee6fd
Compare
|
Hi @zihanKuang , Apologies for mixing up the contents. |
|
Hi @HIMU-2001 , it seems there's a formatting issue with the tightly grouped headings that have no text in between them.
original: |
Signed-off-by: HIMANSHU RAI <himanshuuu.2001@gmail.com>
|
Hi @zihanKuang , I have fixed the formatting issue. Current state : |
zihanKuang
approved these changes
Jun 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes for Reviewers
Implemented heading permalinks across all Markdown heading levels using Hugo’s render-heading.html hook. Added a chain icon (🔗) that appears on hover for easy linking, with smooth transitions and consistent sizing for better UX.
This PR fixes #596
Signed commits