Skip to content

[Improvment] exposed Html for cloud/white-labeling page and footer 'Edit this page' link #611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 20, 2025

Conversation

Namanv0509
Copy link
Contributor

@Namanv0509 Namanv0509 commented Jun 20, 2025

Notes for Reviewers

  1. I did a quick for single quote parsing issue for header , but for a more permanent fix we will have to mark smartypants as false as its automatically converting the single quotes
    This PR fixes #
  2. exposed HTML at head https://docs.layer5.io/cloud/self-hosted/white-labeling/#customizing-your-organizations-dashboard. the issue was with the single quotes getting parsed incorrectly
  3. updates the link at the footer for "Edit this page" with the correct link.

Signed commits

  • Yes, I signed my commits.

…dit this page' link

Signed-off-by: Namanv0509 <namanverma00260@gmail.com>
Copy link

netlify bot commented Jun 20, 2025

Deploy Preview for bejewelled-pegasus-b0ce81 ready!

Name Link
🔨 Latest commit 12a0efa
🔍 Latest deploy log https://app.netlify.com/projects/bejewelled-pegasus-b0ce81/deploys/6855535b0016c70008da21a0
😎 Deploy Preview https://deploy-preview-611--bejewelled-pegasus-b0ce81.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@Namanv0509 Namanv0509 changed the title [Improvment] exposed Html for cloud/white-labeling page and footer 'E… [Improvment] exposed Html for cloud/white-labeling page and footer 'Edit this page' link Jun 20, 2025
Copy link
Contributor

@zihanKuang zihanKuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zihanKuang zihanKuang merged commit 3fd5e70 into layer5io:master Jun 20, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants