-
Notifications
You must be signed in to change notification settings - Fork 1.4k
[Docs] Add Dialog component with overview, guidance, and code examples #6605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Docs] Add Dialog component with overview, guidance, and code examples #6605
Conversation
Signed-off-by: Ayush More <ayushmore42595@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here's the clue that you're looking for - https://github.com/layer5io/layer5/actions/runs/16073904323/job/45364514434?pr=6605#step:3:137
…s #9305 Signed-off-by: Ayush More <ayushmore42595@gmail.com>
ab29e3f
to
2dbe72a
Compare
🚀 Preview for commit 2dbe72a at: https://6868702f74ef27512235a9a1--layer5.netlify.app |
Signed-off-by: Ayush More <ayushmore42595@gmail.com>
🚀 Preview for commit 9d5d52e at: https://686917a274ef27dfa235a90e--layer5.netlify.app |
@Ayushmore1214 , looks good. Nice job!!! |
Sure @vr-varad I'll make changes soon |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Ayushmore1214 please take a look at failing check otherwise looks good. @vr-varad i don't think we need for now more examples, we already have the modal component documented so @Ayushmore1214 you can point or redirect to that component if required as example. what say @vr-varad ?
Okayy , Give me some time |
Hi @sudhanshutech can you provide the correct link or file path for the documented modal component you’re referring to? |
Signed-off-by: Ayush More <ayushmore42595@gmail.com>
🚀 Preview for commit a74d358 at: https://686e6df8b55bae5716c3b480--layer5.netlify.app |
Signed-off-by: Ayush More <ayushmore42595@gmail.com>
🚀 Preview for commit ec14ac4 at: https://686e72cec9bfde53a37252cf--layer5.netlify.app |
@vr-varad I have made changes as you asked plz have a look at them |
🚀 Preview for commit af10ec8 at: https://6874a718457edda08240eaa5--layer5.netlify.app |
Thank you @Ayushmore1214 for your contribution. |
Welcome @vr-varad ! |
Description
This PR fixes #6598
Notes for Reviewers
Signed commits