Skip to content

[Docs] Add Dialog component with overview, guidance, and code examples #6605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 14, 2025

Conversation

Ayushmore1214
Copy link
Contributor

Description

This PR fixes #6598

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

Signed-off-by: Ayush More <ayushmore42595@gmail.com>
Copy link
Member

@leecalcote leecalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

…s #9305

Signed-off-by: Ayush More <ayushmore42595@gmail.com>
@Ayushmore1214 Ayushmore1214 force-pushed the add/dialog-component-v2 branch from ab29e3f to 2dbe72a Compare July 5, 2025 00:07
@l5io
Copy link
Contributor

l5io commented Jul 5, 2025

🚀 Preview for commit 2dbe72a at: https://6868702f74ef27512235a9a1--layer5.netlify.app

Signed-off-by: Ayush More <ayushmore42595@gmail.com>
@l5io
Copy link
Contributor

l5io commented Jul 5, 2025

🚀 Preview for commit 9d5d52e at: https://686917a274ef27dfa235a90e--layer5.netlify.app

@vr-varad
Copy link
Contributor

vr-varad commented Jul 5, 2025

@Ayushmore1214 , looks good. Nice job!!!
It would be nice to showcase more examples and usage if you could under diff scenarios. (something like full-screen etc)

@Ayushmore1214
Copy link
Contributor Author

Sure @vr-varad I'll make changes soon

Copy link
Member

@sudhanshutech sudhanshutech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ayushmore1214 please take a look at failing check otherwise looks good. @vr-varad i don't think we need for now more examples, we already have the modal component documented so @Ayushmore1214 you can point or redirect to that component if required as example. what say @vr-varad ?

@Ayushmore1214
Copy link
Contributor Author

Okayy , Give me some time

@Ayushmore1214
Copy link
Contributor Author

Hi @sudhanshutech can you provide the correct link or file path for the documented modal component you’re referring to?

Signed-off-by: Ayush More <ayushmore42595@gmail.com>
@l5io
Copy link
Contributor

l5io commented Jul 9, 2025

🚀 Preview for commit a74d358 at: https://686e6df8b55bae5716c3b480--layer5.netlify.app

Signed-off-by: Ayush More <ayushmore42595@gmail.com>
@l5io
Copy link
Contributor

l5io commented Jul 9, 2025

🚀 Preview for commit ec14ac4 at: https://686e72cec9bfde53a37252cf--layer5.netlify.app

@Ayushmore1214
Copy link
Contributor Author

@vr-varad I have made changes as you asked plz have a look at them

@l5io
Copy link
Contributor

l5io commented Jul 14, 2025

🚀 Preview for commit af10ec8 at: https://6874a718457edda08240eaa5--layer5.netlify.app

@vr-varad vr-varad merged commit b95d83d into layer5io:master Jul 14, 2025
5 checks passed
@vr-varad
Copy link
Contributor

Thank you @Ayushmore1214 for your contribution.

@Ayushmore1214
Copy link
Contributor Author

Welcome @vr-varad !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants