Handbook Table Theme Fix #6612
Handbook Table Theme Fix #6612
Conversation
Signed-off-by: Namanv0509 <namanverma00260@gmail.com>
|
🚀 Preview for commit d743dc5 at: https://686bb6f5fab5ec7cb49c0aeb--layer5.netlify.app |
|
try to use semantic background colors , they handle light and dark mode better |
|
No need to create or modify already made colors |
| @@ -162,7 +162,7 @@ export const HandbookWrapper = styled.div` | |||
| } | |||
| td, th { | |||
| border: 0.05rem solid ${(props) => props.theme.primaryLightColor}; | |||
There was a problem hiding this comment.
@Namanv0509 I don't this the error is with td, th.
The error is with tbody, and if u look up the inspect u might find this
so any other CSS is overlapping and that might me the issue
There was a problem hiding this comment.
Yes i was skeptical on it , will try to find the overlapping. Thanks @vr-varad
There was a problem hiding this comment.
ooh with the td tb , when i was toggling theme , the border colors also had an issue i found and not only the cells , thats why i changed that too . @vr-varad
Sure , i will keep that in mind from next time @FaheemOnHub |
Signed-off-by: Namanv0509 <namanverma00260@gmail.com>
|
🚀 Preview for commit d814cb7 at: https://686c388e2144422a4c598ad7--layer5.netlify.app |
|
@vr-varad Can you help reviewing this. |
| @@ -1,6 +1,78 @@ | |||
| import styled from "styled-components"; | |||
| export const HandbookWrapper = styled.div` | |||
|
|
|||
| /* repository overview */ | |||
There was a problem hiding this comment.
what is the change @Namanv0509
|
@Namanv0509 I would suggest a diff pr for that issue!! |
@vr-varad Yeah sure , If this PR looks good , i will get the other PR up in a min. |
|
A Summary to PR changes Below are SS for the page after the PR for the pages which conatined Tables and invite-only-program Repository Overview :
Security Vulnerability :
Github Process :
No Other Pages faced any defacement or any unwanted changes due to this update in Handbook.style.js |
Description
This PR fixes #
The Theme Toggle issue faced by Handbook Tables and some Other components
This 1st PR is only to fix the table
Before
After
Notes for Reviewers
The same table issue was found in all handbook pages
There is also problem is invite-only class colors and some text classes , if this goes well will update similar to them also
Signed commits