Skip to content

refactor: removing the UseLocalBuild flag and updated scripts to run local docker build manually post deployment #521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: dev
Choose a base branch
from

Conversation

Harsh-Microsoft
Copy link
Contributor

Purpose

This pull request introduces significant changes to simplify and improve the deployment process by removing the useLocalBuild parameter and implementing a more robust container registry and managed identity-based workflow. The changes span across multiple files, including Bicep templates, documentation, and deployment scripts. Below is a summary of the most important changes grouped by theme.

Removal of useLocalBuild Parameter:

  • Removed the useLocalBuild parameter from multiple Bicep templates (infra/deploy_app_service.bicep, infra/deploy_backend_docker.bicep, infra/deploy_frontend_docker.bicep, infra/main.bicep) and associated logic for conditional ACR role assignments. [1] [2] [3] [4]
  • Eliminated conditional resource definitions for container registry and role assignments based on useLocalBuild. [1] [2]

Enhanced Container Registry Configuration:

  • Added new parameters (acrPullPrincipalIds, acrSku) to infra/deploy_container_registry.bicep to support role assignments and customizable ACR tier. [1] [2]

Improved Deployment Scripts:

  • Refactored infra/scripts/docker-build.ps1 to dynamically fetch environment values using azd env get-values and removed reliance on useLocalBuild. Added steps to update web app settings and restart web apps after image deployment. [1] [2]

Documentation Updates:

  • Removed references to USE_LOCAL_BUILD from documentation files (documents/CustomizingAzdParameters.md, documents/DeploymentGuide.md) and added instructions for publishing local build containers. [1] [2] [3]

Workflow Enhancements:

  • Updated .github/workflows/test-automation.yml to use workflow_call for reusability, removing branch-specific triggers.

These changes collectively simplify the deployment process, improve maintainability, and enhance support for managed identities and container registry configurations.

Does this introduce a breaking change?

  • Yes
  • No

Golden Path Validation

  • I have tested the primary workflows (the "golden path") to ensure they function correctly without errors.

Deployment Validation

  • I have validated the deployment process successfully and all services are running as expected with this change.

What to Check

Verify that the following are valid

  • ...

Other Information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant