refactor: removing the UseLocalBuild flag and updated scripts to run local docker build manually post deployment #521
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request introduces significant changes to simplify and improve the deployment process by removing the
useLocalBuild
parameter and implementing a more robust container registry and managed identity-based workflow. The changes span across multiple files, including Bicep templates, documentation, and deployment scripts. Below is a summary of the most important changes grouped by theme.Removal of
useLocalBuild
Parameter:useLocalBuild
parameter from multiple Bicep templates (infra/deploy_app_service.bicep
,infra/deploy_backend_docker.bicep
,infra/deploy_frontend_docker.bicep
,infra/main.bicep
) and associated logic for conditional ACR role assignments. [1] [2] [3] [4]useLocalBuild
. [1] [2]Enhanced Container Registry Configuration:
acrPullPrincipalIds
,acrSku
) toinfra/deploy_container_registry.bicep
to support role assignments and customizable ACR tier. [1] [2]Improved Deployment Scripts:
infra/scripts/docker-build.ps1
to dynamically fetch environment values usingazd env get-values
and removed reliance onuseLocalBuild
. Added steps to update web app settings and restart web apps after image deployment. [1] [2]Documentation Updates:
USE_LOCAL_BUILD
from documentation files (documents/CustomizingAzdParameters.md
,documents/DeploymentGuide.md
) and added instructions for publishing local build containers. [1] [2] [3]Workflow Enhancements:
.github/workflows/test-automation.yml
to useworkflow_call
for reusability, removing branch-specific triggers.These changes collectively simplify the deployment process, improve maintainability, and enhance support for managed identities and container registry configurations.
Does this introduce a breaking change?
Golden Path Validation
Deployment Validation
What to Check
Verify that the following are valid
Other Information