Fix German localization Y/N prompt validation issues #5241
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mpt strings Co-authored-by: sanjuyadav24 <185911972+sanjuyadav24@users.noreply.github.com>
Copilot
AI
changed the title
Copilot finished work on behalf of
sanjuyadav24
June 11, 2025 09:06
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
During deployment group agent setup in German locale, prompts incorrectly displayed "J/N" (German for "Ja/Nein") but the validation system expected "Y/N" responses, causing user confusion and validation errors.
Users would see prompts like:
Even when responding with "j" (German "yes"), validation would fail because the
BoolValidatorexpects Y/N responses.Root Cause
The
BoolValidatorinsrc/Agent.Listener/Configuration/Validators.csvalidates responses againstStringUtil.Loc("Y")andStringUtil.Loc("N"), which are correctly set to "Y" and "N" in all locales including German. However, the German prompt strings incorrectly used "J/N" in the display text, creating a mismatch between what users see and what the validator accepts.Solution
src/Misc/layoutbin/de-DE/strings.jsonto use "Y/N" instead of "J/N"EnableServiceSidTypeUnrestrictedto avoid confusion about entering long stringsKey strings fixed:
EnableServiceSidTypeUnrestricted: Now clearly asks whether to enable the feature (Y/N)PreventServiceStartDescription: Uses Y/N instead of J/NAcceptTeeEula,AddDeploymentGroupTagsFlagDescription, and 8 other prompt stringsTesting
Impact
✅ German users now see consistent Y/N prompts matching validation expectations
✅ No more validation errors when responding to German prompts
✅ Clearer prompt text reduces user confusion
✅ Zero impact on other languages or existing functionality
Fixes #5233.
Warning
Firewall rules blocked me from connecting to one or more addresses
I tried to connect to the following addresses, but was blocked by firewall rules:
03nvsblobprodwcus014.vsblob.vsassets.iodotnet build azure-pipelines-agent.sln(dns block)055vsblobprodwcus02.vsblob.vsassets.iodotnet build azure-pipelines-agent.sln(dns block)1g1vsblobprodwcus01.vsblob.vsassets.iodotnet build azure-pipelines-agent.sln(dns block)3eavsblobprodwcus03.vsblob.vsassets.iodotnet build azure-pipelines-agent.sln(dns block)3zgvsblobprodwcus024.vsblob.vsassets.iodotnet build azure-pipelines-agent.sln(dns block)40qvsblobprodwcus022.vsblob.vsassets.iodotnet build azure-pipelines-agent.sln(dns block)4fdvsblobprodwcus012.vsblob.vsassets.iodotnet build azure-pipelines-agent.sln(dns block)5tbvsblobprodwcus06.vsblob.vsassets.iodotnet build azure-pipelines-agent.sln(dns block)61cvsblobprodwcus010.vsblob.vsassets.iodotnet build azure-pipelines-agent.sln(dns block)73dvsblobprodwcus07.vsblob.vsassets.iodotnet build azure-pipelines-agent.sln(dns block)8usvsblobprodwcus011.vsblob.vsassets.iodotnet build azure-pipelines-agent.sln(dns block)9owvsblobprodwcus020.vsblob.vsassets.iodotnet build azure-pipelines-agent.sln(dns block)arpvsblobprodwcus017.vsblob.vsassets.iodotnet build azure-pipelines-agent.sln(dns block)crcvsblobprodwcus021.vsblob.vsassets.iodotnet build azure-pipelines-agent.sln(dns block)fslvsblobprodwcus015.vsblob.vsassets.iodotnet build azure-pipelines-agent.sln(dns block)uubvsblobprodwcus018.vsblob.vsassets.iodotnet build azure-pipelines-agent.sln(dns block)vwmvsblobprodwcus016.vsblob.vsassets.iodotnet build azure-pipelines-agent.sln(dns block)xg1vsblobprodwcus019.vsblob.vsassets.iodotnet build azure-pipelines-agent.sln(dns block)xlkvsblobprodwcus023.vsblob.vsassets.iodotnet build azure-pipelines-agent.sln(dns block)If you need me to access, download, or install something from one of these locations, you can either: