Add domain support to pipeline caching #5260
Merged
+52
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
johnterickson
approved these changes
Jul 7, 2025
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
fadnavistanmay
approved these changes
Jul 7, 2025
tarunramsinghani
approved these changes
Jul 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Adds support for multiple storage domains to the pipeline cache experience, allowing users to specify different domains for their pipeline cache storage.
Description
On upload, checks to see if the user has set the cache domain via an agent knob, and if not, checks if the domain has been overridden via client settings, and if not uses the default domain.
On download, checks the returned cache artifact if it has an associated domain, if it does, it uses that domain. If it doesn't, it uses the default domain for backward compatibility.
Risk Assessment (Low / Medium / High)
Low - behavior is opt-in via the pipeline variable. Eventually the default may be changed via client settings, but that is easily reversible and can be overridden on a pipeline basis. Finally caching is a best-effort experience, so cache failures are expected an should not fail the build.
Unit Tests Added or Updated (Yes / No)
No - requires multiple domains and service support.
Additional Testing Performed
Manually tested override in testing org using a locally deployed version of the agent.