[exporter/awsxray] Fix URL Path and Query #40833
Open
+40
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The committers listed above are authorized under a signed CLA. |
Comment on lines
110
to
+115
| case string(conventions.URLPathKey): | ||
| urlParts[key] = value.Str() | ||
| hasHTTP = true | ||
| case string(conventions.URLQueryKey): | ||
| urlParts[key] = value.Str() | ||
| hasHTTP = true |
There was a problem hiding this comment.
Maybe we just combine these two cases:
Suggested change
| case string(conventions.URLPathKey): | |
| urlParts[key] = value.Str() | |
| hasHTTP = true | |
| case string(conventions.URLQueryKey): | |
| urlParts[key] = value.Str() | |
| hasHTTP = true | |
| case string(conventions.URLPathKey), string(conventions.URLQueryKey): | |
| urlParts[key] = value.Str() | |
| hasHTTP = true |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When url.query is present among attributes, the output HTTP Url is invalid because url.path is omitted
Link to tracking issue
Fixes #38242
Testing
Added a test with url.query attribute and check output url contains url.path