-
Notifications
You must be signed in to change notification settings - Fork 2.8k
[chore][receiver/sqlserver] provide one generic configuration in readme #40851
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[chore][receiver/sqlserver] provide one generic configuration in readme #40851
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly just wording nits, thanks for adding!
Co-authored-by: Curtis Robert <crobert@splunk.com>
|
server: sqlserver.address | ||
port: 1433 | ||
events: | ||
db.server.query_sample: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently, to enable or disable a collection, we have to configure it under events
rather than within the collection
-related section. Personally, I find this a bit unintuitive.
Do you think it would be feasible to modify this on mdatagen side, so that enable/disable configuration could live in the same section as the rest of the collection settings?
@sincejune
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The solution I came up with is to add a parameters section to the metadata file, structured as follows:
parameters:
<param>:
type: int
default: <default_value>
events:
default_event:
attributes: [...]
parameters:
<param>: <value>
This approach works well for parameters that will be used within a single collection. However, it may not be ideal for parameters that need to be shared across multiple collections (e.g., metrics or events).
@dmitryax what do you think?
Description
we now have many different configurations but the current readme does not have one generic readme that user can use directly.
Link to tracking issue
Fixes
Testing
Documentation
/cc @natalie-arsky