-
Notifications
You must be signed in to change notification settings - Fork 3k
[redisreceiver] Fix metric types and units according to Redis semantics #40852
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- master | ||
- slave | ||
- sentinel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added these based on the documentation: https://redis.io/docs/latest/commands/role/
Also, I took a INFO
dump by connecting redis-cli to redis-server, I got this output:
# Replication
role:master
And master was not there in the enum. Also, added it to the last to maintain the enum order.
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
@shmsr I am pinging the codeowners on slack - please review the conflict. |
I don't see why the metrics have to be gauges. They are additive meaning if they are re-agregated, the values should be summed up. They seem to me proper UpDownCounters. See https://github.com/open-telemetry/opentelemetry-specification/blob/8aa1d27d9cf8c224299dcf0b58bfd5fcaacf88eb/specification/metrics/supplementary-guidelines.md#guidelines-for-instrumentation-library-authors for more details. See #23454 for the second item. Looks like you're reverting it. We should avoid Please submit a separate PRs for each item where still applicable |
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
Description
redis.clients.blocked
- current count of clients pending on blocking callsredis.clients.connected
- current count of client connectionsredis.rdb.changes_since_last_save
- current count of changes since last dumpredis.slaves.connected
- current count of connected replicasredis.role
- current role indicatorredis.replication.backlog_first_byte_offset
redis.replication.offset
redis.replication.replica_offset
role
attribute enum:master
,slave
,sentinel
Link to tracking issue
Fixes #40814
Testing
Documentation