Skip to content

[exporter/coralogix] Remove unused deprecated configgrpc.ClientConfig #40853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Aug 20, 2025
Merged

[exporter/coralogix] Remove unused deprecated configgrpc.ClientConfig #40853

merged 10 commits into from
Aug 20, 2025
+27 −51

Conversation

VihasMakwana
Copy link
Contributor

@VihasMakwana VihasMakwana commented Jun 21, 2025 •
edited
Loading

Description

Remove unused deprecated configgrpc.ClientConfig. This field was marked as deprecated in v0.60.0 and is not used anywhere in the code.

@VihasMakwana VihasMakwana requested a review from a team as a code owner June 21, 2025 18:47
@VihasMakwana VihasMakwana requested a review from ArthurSens June 21, 2025 18:47
ChrsMark
ChrsMark reviewed Jun 23, 2025
View reviewed changes
Copy link
Member

@ChrsMark ChrsMark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@VihasMakwana please resolve the conflicts here.

@VihasMakwana VihasMakwana requested a review from ChrsMark June 23, 2025 08:15
@VihasMakwana
Copy link
Contributor Author

@ChrsMark Done!

@codeboten
Copy link
Contributor

Looks like there were some failing tests:

=== FAIL: . TestLogsExporter (0.00s)
    config_test.go:190: 
        	Error Trace:	/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/exporter/coralogixexporter/config_test.go:190
        	Error:      	Received unexpected error:
        	            	decoding failed due to the following error(s):
        	            	
        	            	'' has invalid keys: endpoint
        	Test:       	TestLogsExporter

=== FAIL: . TestMetricsExporter (re-run 1) (0.00s)
    config_test.go:170: 
        	Error Trace:	/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/exporter/coralogixexporter/config_test.go:170
        	Error:      	Received unexpected error:
        	            	decoding failed due to the following error(s):
        	            	
        	            	'' has invalid keys: endpoint
        	Test:       	TestMetricsExporter

=== FAIL: . TestLogsExporter (re-run 1) (0.00s)
    config_test.go:190: 
        	Error Trace:	/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/exporter/coralogixexporter/config_test.go:190
        	Error:      	Received unexpected error:
        	            	decoding failed due to the following error(s):
        	            	
        	            	'' has invalid keys: endpoint
        	Test:       	TestLogsExporter

@VihasMakwana
Copy link
Contributor Author

Hmm. Let me take a look.

@VihasMakwana
Copy link
Contributor Author

@codeboten this should be good to go now!

iblancasa
iblancasa suggested changes Jun 25, 2025
View reviewed changes
exporter/coralogixexporter/config.go
Comment on lines 89 to 90
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this removed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iblancasa the Headers was part of configgrpc.ClientConfig and it was not used anywhere in the code. Your refactoring PR took care of updating PrivateKey in headers: #40044.

@VihasMakwana VihasMakwana requested a review from iblancasa June 25, 2025 10:20
@VihasMakwana
Copy link
Contributor Author

@iblancasa Can you please take a at this PR?

@atoulme
Copy link
Contributor

atoulme commented Jul 14, 2025

Please resolve conflicts and mark ready to review again

@atoulme atoulme marked this pull request as draft July 14, 2025 05:56
@github-actions GitHub Actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Jul 29, 2025
@github-actions GitHub Actions
Copy link
Contributor

Closed as inactive. Feel free to reopen if this PR is still being worked on.

@github-actions github-actions bot closed this Aug 13, 2025
@VihasMakwana VihasMakwana reopened this Aug 18, 2025
@github-actions github-actions bot removed the Stale label Aug 18, 2025
@douglascamata
Copy link
Member

Hey @VihasMakwana, don't forget to mark the PR as ready for review when you are done with your work so that we can review and merge it. Thank you!

@VihasMakwana VihasMakwana marked this pull request as ready for review August 19, 2025 15:23
@VihasMakwana
Copy link
Contributor Author

@douglascamata Thanks for your ping!! I completely missed it.

@atoulme atoulme merged commit 8dc22b2 into open-telemetry:main Aug 20, 2025
191 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atoulme atoulme

@codeboten codeboten

@ChrsMark ChrsMark

@ArthurSens ArthurSens

@douglascamata douglascamata

@povilasv povilasv

+1 more reviewer

@iblancasa iblancasa

Reviewers whose approvals may not affect merge requirements
Assignees

@ChrsMark ChrsMark

@crobert-1 crobert-1

Labels
exporter/coralogix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@VihasMakwana @codeboten @atoulme @douglascamata @iblancasa @ChrsMark @crobert-1