[chore] Add phony govulncheck on root #13204
Conversation
Signed-off-by: sivchari <shibuuuu5@gmail.com>
Signed-off-by: sivchari <shibuuuu5@gmail.com>
github-actions
bot
added
the
release:risky-change
| .PHONY: vulncheck | ||
| vulncheck: $(GOVULNCHECK) | ||
| $(GOVULNCHECK) ./... |
There was a problem hiding this comment.
Does this not check all files or only the files within that module?
There was a problem hiding this comment.
Makefile.Common actually check only files for each module. If you'd like to check all files, you can use make govulncheck in Makefile. That is same with other structure (e.g. make golint/lint)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #13204 +/- ##
=======================================
Coverage 91.27% 91.27%
=======================================
Files 514 514
Lines 28857 28857
=======================================
Hits 26340 26340
Misses 1998 1998
Partials 519 519 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sivchari
changed the title
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
If you have time, please review it. |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
kindly ping |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
Description
I added phony govulncheck on root, then I found that the some target can't run govulncheck on itself, so change the phony name in Makefile.Common.
Link to tracking issue
Fixes #
Testing
Documentation