Skip to content

Introduce SetFunction for profiles #13222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 21, 2025
Merged

Conversation

dmathieu
Copy link
Member

Description

This is part of #13106
It introduces a new SetFunction method, which allows setting a line's function based on a specific dictionary.

Related: #13197

@github-actions github-actions bot requested review from bogdandrutu and dmitryax June 17, 2025 08:12
Copy link

codecov bot commented Jun 17, 2025

Codecov Report

Attention: Patch coverage is 65.51724% with 10 lines in your changes missing coverage. Please review.

Project coverage is 91.47%. Comparing base (be09659) to head (baf5b35).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pdata/pprofile/functions.go 58.33% 7 Missing and 3 partials ⚠️

❌ Your patch status has failed because the patch coverage (65.51%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13222      +/-   ##
==========================================
- Coverage   91.48%   91.47%   -0.02%     
==========================================
  Files         529      531       +2     
  Lines       29508    29537      +29     
==========================================
+ Hits        26996    27018      +22     
- Misses       1985     1990       +5     
- Partials      527      529       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dmathieu dmathieu marked this pull request as ready for review June 17, 2025 08:24
@dmathieu dmathieu requested review from mx-psi and a team as code owners June 17, 2025 08:24
Copy link
Contributor

github-actions bot commented Jul 2, 2025

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Jul 2, 2025
@dmathieu
Copy link
Member Author

dmathieu commented Jul 2, 2025

Bump for review. This is needed to bring back batching support for profiles.

@mx-psi
Copy link
Member

mx-psi commented Jul 2, 2025

Bump for review. This is needed to bring back batching support for profiles.

Let's resolve the discussion over at #13225 first

@github-actions github-actions bot removed the Stale label Jul 3, 2025
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Jul 17, 2025
@dmathieu
Copy link
Member Author

This is not stale.

Copy link
Member

@mx-psi mx-psi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, same as with the SetString PR, let's discuss the naming over at #13440

@mx-psi mx-psi enabled auto-merge July 21, 2025 10:58
@mx-psi mx-psi added this pull request to the merge queue Jul 21, 2025
Merged via the queue into open-telemetry:main with commit 27e88dc Jul 21, 2025
55 of 56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants