-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Introduce SetFunction for profiles #13222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
❌ Your patch status has failed because the patch coverage (65.51%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #13222 +/- ##
==========================================
- Coverage 91.48% 91.47% -0.02%
==========================================
Files 529 531 +2
Lines 29508 29537 +29
==========================================
+ Hits 26996 27018 +22
- Misses 1985 1990 +5
- Partials 527 529 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
Bump for review. This is needed to bring back batching support for profiles. |
Let's resolve the discussion over at #13225 first |
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
This is not stale. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, same as with the SetString
PR, let's discuss the naming over at #13440
27e88dc
Description
This is part of #13106
It introduces a new
SetFunction
method, which allows setting a line's function based on a specific dictionary.Related: #13197