Skip to content

Add processor duration metric #13227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Add processor duration metric #13227

wants to merge 7 commits into from
+183 −3

Conversation

andborja
Copy link

@andborja andborja commented Jun 17, 2025 •
edited
Loading

Description

Add duration metric to processors.

Testing

Unit tests added.

Documentation

Implements issue Processor duration metric #13231.

Basic documentation generated by mdatagen.

@andborja andborja requested a review from a team as a code owner June 17, 2025 17:19
@andborja andborja requested a review from mx-psi June 17, 2025 17:19
@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Jun 17, 2025 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@andborja andborja marked this pull request as draft June 17, 2025 17:19
@andborja andborja force-pushed the andborja/procDuration branch 2 times, most recently from 7f57384 to 2ab1342 Compare June 17, 2025 22:31
@andborja andborja marked this pull request as ready for review June 18, 2025 16:40
@andborja andborja mentioned this pull request Jun 18, 2025
Open
@atoulme
Copy link
Contributor

atoulme commented Jun 18, 2025

@andborja please make sure you review and sign the CLA.

@andborja
Copy link
Author

@andborja please make sure you review and sign the CLA.

Thanks @atoulme. I just created a ticket for it.

@andborja andborja force-pushed the andborja/procDuration branch from 077c9b3 to d25590d Compare June 18, 2025 21:48
axw
axw reviewed Jun 19, 2025
View reviewed changes
cijothomas
cijothomas reviewed Jun 19, 2025
View reviewed changes
axw
axw approved these changes Jun 20, 2025
View reviewed changes
Copy link
Contributor

@axw axw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, would like to see the test simplified though. Thanks for adding this!

bogdandrutu
bogdandrutu approved these changes Jun 23, 2025
View reviewed changes
@jmacd
Copy link
Contributor

jmacd commented Jun 23, 2025

Looking forward to exporter and receiver metrics!

@github-actions github-actions bot requested a review from bogdandrutu June 24, 2025 00:32
@jmacd
Copy link
Contributor

jmacd commented Jun 24, 2025

Ready to merge, I think.

Quoting a user on slack:

I'd be ecstatic to see latency metrics

@andborja ^^^ looking forward to exporter and receiver 💥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cijothomas cijothomas cijothomas left review comments

@axw axw axw approved these changes

@jmacd jmacd jmacd approved these changes

@mx-psi mx-psi Awaiting requested review from mx-psi mx-psi is a code owner automatically assigned from open-telemetry/collector-approvers

@codeboten codeboten Awaiting requested review from codeboten codeboten is a code owner

@dmitryax dmitryax Awaiting requested review from dmitryax dmitryax is a code owner

@bogdandrutu bogdandrutu Awaiting requested review from bogdandrutu bogdandrutu is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@andborja @atoulme @jmacd @axw @bogdandrutu @cijothomas