fix(frontend): switch off the http instrumentation to avoid duplicate spans #2191
Conversation
cedricziel
changed the title
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
There was a problem hiding this comment.
Same thing as #2190 (review)
We should raise this to the js SIG and try to solve in the instrumentation side.
Meanwhile in the Demo we can have the transform processor taking care of it on the Collector.
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
|
I agree that having 2 server spans is not ideal, but disabling the HTTP auto instrumentation may not be the ideal situation here. The HTTP instrumented span contains several details that are not part of the Next.js span. I do agree with Juliano that this is an instrumentation issue that should be fixed there. Perhaps we should use a collector transform rule to change the span kind for the Next.js spans instead? |
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
NOTE: this is a followup of #2190 in relation to #2189
Changes
Turn off instrumentation for incoming http requests in frontend. This avoids creating duplicate spans.
Needs to be thoroughly validated.