Skip to content

Adding OTel grpc logger to Product Catalog #2285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

kerneljack
Copy link

Changes

Added OTLP Logs to the Product Catalog service, using the slog logger.

I wasn't sure whether "attributes" on the log output are desirable so I've left an example in the code on line 279. If this is too verbose and we don't need the logs as "attributes", I am happy to remove it, please let me know.

I have added a couple of screenshots to show this working in Grafana. The first is the simple log output and the second screenshot shows the attributes being displayed as well.

loaded_products
attributes

Merge Requirements

For new features contributions, please make sure you have completed the following
essential items:

  • [ *] CHANGELOG.md updated to document new feature additions
  • Appropriate documentation updates in the docs
  • Appropriate Helm chart updates in the helm-charts

Maintainers will not merge until the above have been completed. If you're unsure
which docs need to be changed ping the
@open-telemetry/demo-approvers.

@kerneljack kerneljack requested a review from a team as a code owner June 19, 2025 20:42
Copy link

linux-foundation-easycla bot commented Jun 19, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

@puckpuck
Copy link
Contributor

puckpuck commented Jun 21, 2025

@kerneljack can you resolve conflicts then rebuild the product-catalog service. There was some changes recently to the openfeature.SetProvider call which may need to be implemented when you resolve. See this commit for details.

@kerneljack
Copy link
Author

@puckpuck I think I've fixed it. I've re-tested that the product catalog still works

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants