-
Notifications
You must be signed in to change notification settings - Fork 21
Introduce granular (service selector) export modes #276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rafaelroquetto
wants to merge
10
commits into
open-telemetry:main
Choose a base branch
from
rafaelroquetto:discovery
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #276 +/- ##
==========================================
+ Coverage 72.04% 77.07% +5.02%
==========================================
Files 181 181
Lines 19742 19820 +78
==========================================
+ Hits 14224 15276 +1052
+ Misses 4731 3756 -975
- Partials 787 788 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cb3e211
to
a53ceba
Compare
mariomac
reviewed
Jul 10, 2025
mariomac
reviewed
Jul 10, 2025
5201152
to
3528433
Compare
The last set criterion overrides a previous one
e2f10e8
to
6f39fd1
Compare
b8fccc7
to
e60360f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a per service-selector export mode. This allows individual selectors to specify whether they want to:
exports: [metrics]
)exports: [traces]
)exports: [metrics, traces]
)exports: []
)exports:
not present /nil
)The selection criteria are applied in order of appearance. For example, consider the following sample configuration for discovering a service called
planet-service
which lives in thedefault
namespace:Because selectors are processed in sequential order of appearance (selector 2 appears after selector 1), the resulting configuration will only enable traces export for
planet-service
. Whilst this PR only adds a newexport
attribute, this paves the road for future attributes to be added and allows for configurations to be stacked. For instance, we can decide to export metrics and traces for the entire default namespace, except forplanet-service
, which exports metrics only:Omitting the
exports
attribute falls back to the conventional behaviour that relies on variables such asOTEL_EXPORTER_OTLP_ENDPOINT
, i.e. they are orthogonal (unless of course the same service has been matched by a previous selector, as in the examples above). For instance, if a service selector specifiesexport: traces
but no trace endpoint is defined, then obviously no traces will be generated.This PR is best reviewed on a per-commit basis