-
Notifications
You must be signed in to change notification settings - Fork 679
Remove StreamClientInterceptor
#7126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@MrAlias I have signed the EasyCLA as you instructed me. I assume i have to wait for your validation. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7126 +/- ##
=======================================
- Coverage 80.7% 80.6% -0.1%
=======================================
Files 205 205
Lines 18083 17977 -106
=======================================
- Hits 14601 14505 -96
+ Misses 3062 3057 -5
+ Partials 420 415 -5
🚀 New features to boost your workflow:
|
3c39ff0
to
fa6ad66
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution. This looks good overall. Only feedback is on the changelog entry and a minor nit about the comment. Thanks again.
assert.Equal(t, codes.Error, span.Status().Code) | ||
} | ||
|
||
// serverChecks can't be removed in #7105. Should be removed when issue #7106 is fixed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// serverChecks can't be removed in #7105. Should be removed when issue #7106 is fixed. | |
// TODO: Remove when issue #7106 is fixed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#7106 has been fixed, since it's closed. Should serverChecks
be removed?
StreamClientInterceptor
@adambl06, are you able to update the PR? |
Ping @adambl06 for a PR update? |
@dmathieu Thanks for the ping ! I did update the PR and deleted serversChecks and all the unused functions and dependencies. By running the make checks , it turned out that I had to deleted all the unused functions in stats_handler_test.go. Let me know if you wanted to do it differently and I'll change it. Thanks ! |
Your PR still has merge conflicts though. |
@adambl06, can you please update the branch? |
Thanks for the contribution, but I'm going to close this as it looks stale. If you are still able to work on this, please update based on feedback and merge with |
I removed the deprecated code related the deprecated function StreamClientInterceptor.
Side note: serverChecks in interceptor_test.go was not deleted on this branch as used in UnaryServerInterceptor that is cleaned in #7106.
Closes #7105