Always set error type and record error in otelhttp transport

[dmathieu]

Closes #7254

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.3%. Comparing base (088be4b) to head (33d477f).
Report is 41 commits behind head on main.

Additional details and impacted files

@@          Coverage Diff          @@
##            main   #7456   +/-   ##
=====================================
  Coverage   82.3%   82.3%           
=====================================
  Files        205     205           
  Lines      17967   17962    -5     
=====================================
- Hits       14794   14792    -2     
+ Misses      2736    2734    -2     
+ Partials     437     436    -1     

Files with missing lines	Coverage Δ
instrumentation/net/http/otelhttp/transport.go	96.6% <100.0%> (+1.8%)	⬆️

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[pellared]

What is the value of recording the error as event if the type is set as attribute and value (err.Error()) as status description?

An exception SHOULD be recorded as an Event on the span during which it occurred if and only if it remains unhandled when the span ends and causes the span status to be set to ERROR.

I argue that error result is not an exception. For me a panic that was not being recovered is an unhandled exception. We already cover this part of this specification here:

https://github.com/open-telemetry/opentelemetry-go/blob/bc531cb3f9ce9c328b12e473b6409784728dc608/sdk/trace/span.go#L465-L482

Additionally see: https://github.com/open-telemetry/semantic-conventions/blob/main/docs/general/recording-errors.md#recording-errors-on-spans

Therefore, we should not call span.RecordError(err).

Suggested change

span.RecordError(err)

[dmathieu]

Do you want to chime in #7254?

[pellared]

#7254 (comment)

[dmathieu]

Closing per the comment discussion.