Handle "(devel)" version modules #2437
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of failing to parse user modules with a version of "(devel)", use a placeholder version value. These modules are not known to be used by our probes. Failing to parse their version and then failing the instrumentation is not desired behavior. Instead, communicate the development state of the modules by using a placeholder version.
pellared
approved these changes
Jun 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of failing to parse user modules with a version of "(devel)", use a placeholder version value.
These modules are not known to be used by our probes. Failing to parse their version and then failing the instrumentation is not desired behavior. Instead, communicate the development state of the modules by using a placeholder version.
In contrast to #2401, this approach does not drop the parsing of the
(devel)module, nor does it require changing function signatures. If the development version placeholder is used to compare it will always return false (due to the build portion of the version).Supersedes #2401
Fix #2388