Skip to content

fix(opentelemetry-kube-stack): Custom collectors missing empty volumes and volumeMounts arrays during dry-runs #1714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jun 23, 2025
Merged

fix(opentelemetry-kube-stack): Custom collectors missing empty volumes and volumeMounts arrays during dry-runs #1714

merged 7 commits into from
Jun 23, 2025
+28 −28

Conversation

KyriosGN0
Copy link
Contributor

@KyriosGN0 KyriosGN0 commented Jun 13, 2025 •
edited
Loading

Signed-off-by: AvivGuiser avivguiser@gmail.com
fixes #1696

@KyriosGN0
fix(opentelemetry-kube-stack): Custom collectors missing empty volume…
1f22ea0 
…s and volumeMounts arrays during dry-runs

Signed-off-by: AvivGuiser <avivguiser@gmail.com>
@KyriosGN0 KyriosGN0 requested review from jaronoff97 and a team as code owners June 13, 2025 19:57
@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Jun 13, 2025 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

TylerHelmuth
TylerHelmuth reviewed Jun 20, 2025
View reviewed changes
@KyriosGN0
address CR comments
1323660 
Signed-off-by: AvivGuiser <avivguiser@gmail.com>
@KyriosGN0
Copy link
Contributor Author

@TylerHelmuth i have address your comments

@KyriosGN0 KyriosGN0 requested a review from TylerHelmuth June 20, 2025 16:38
KyriosGN0 and others added 2 commits June 21, 2025 03:05
@KyriosGN0
update examples
95ed377 
Signed-off-by: AvivGuiser <avivguiser@gmail.com>
@TylerHelmuth
Merge branch 'main' into volumes
7593771
TylerHelmuth
TylerHelmuth reviewed Jun 23, 2025
View reviewed changes
@KyriosGN0
fix tab
0b47e6c 
Signed-off-by: AvivGuiser <avivguiser@gmail.com>
@KyriosGN0
Copy link
Contributor Author

@TylerHelmuth switched it back to nindent 2 tested locally and it works

@KyriosGN0 KyriosGN0 requested a review from TylerHelmuth June 23, 2025 16:10
@KyriosGN0
ran make generate exmaples
61f102b 
Signed-off-by: AvivGuiser <avivguiser@gmail.com>
@TylerHelmuth TylerHelmuth merged commit 75e667f into open-telemetry:main Jun 23, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaronoff97 jaronoff97 jaronoff97 approved these changes

@TylerHelmuth TylerHelmuth TylerHelmuth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[opentelemetry-kube-stack] Custom collectors missing empty volumes and volumeMounts arrays during dry-runs
3 participants
@KyriosGN0 @jaronoff97 @TylerHelmuth