Skip to content

Composite Samplers Proposal needs clarifications #4566

Open
@PeterF778

Description

@PeterF778

What are you trying to achieve?

The Composite Samplers Proposal attempts to bridge Consistent Probability Samplers with legacy samplers by looking at the parent's sampled flag when no rejection threshold is provided for the parent span. This is expected to correctly handle (albeit with no Consistent Probability Sampling benefits) situations when parent spans are sampled by a non-consistent samplers and the user intention is to follow the parent's sampling decision.

However, the paren't sampled flag may itself depend on the trace randomness value, which can lead to sampling decision not aligned with the user intentions.

The proposal needs to clarify that when making a non-consistent sampling decision, the original trace randomness must not be used.

Tip: React with 👍 to help prioritize this issue. Please use comments to provide useful context, avoiding +1 or me too, to help us triage it. Learn more here.

Metadata

Metadata

Assignees

No one assigned

    Labels

    sig-issueA specific SIG should look into this before discussing at the specspec:traceRelated to the specification/trace directory

    Type

    No type

    Projects

    Status

    No status

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions